----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/#review23840 -----------------------------------------------------------
Has this been applied ?I don't see a commit hash - Sebastien Goasguen On July 24, 2013, 10:26 a.m., Ian Duffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12896/ > ----------------------------------------------------------- > > (Updated July 24, 2013, 10:26 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen. > > > Repository: cloudstack-git > > > Description > ------- > > Cleans up LDAP plugin based on feedback from sonar. > > > Diffs > ----- > > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapAddConfigurationCmd.java > 62736b16087561a7e25893cd46115795100c609e > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapDeleteConfigurationCmd.java > 329b91b > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListAllUsersCmd.java > 087d156 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java > 6707878 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapUserSearchCmd.java > e6a40d0 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java > d583346 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java > 40ba0ce > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java > 2916202 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java > 8f31ce5 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfigurationVO.java > d3ff820 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java > 30bdc5b > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java > be9b3d5 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java > 54802cf > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUtils.java > 453dc0a > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy > 91c9baf > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVO.groovy > 8135901 > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapDeleteConfigurationCmdSpec.groovy > 664fd64 > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListConfigurationCmdSpec.groovy > a7c1979 > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy > d72878b > > Diff: https://reviews.apache.org/r/12896/diff/ > > > Testing > ------- > > Complied... passed unit tests. > Passed integration tests. > > > Thanks, > > Ian Duffy > >
