Re: Review Request 12469: WIP: New implementation of LDAP authentication

2013-07-12 Thread David Nalley
On Fri, Jul 12, 2013 at 7:58 AM, Ian Duffy wrote: > > >> On July 12, 2013, 9:50 a.m., Abhinandan Prateek wrote: >> > Ship It! >> >> Sebastien Goasguen wrote: >> Abhi, I had already applied it to the ldapplugin branch. Did you apply >> the patch somewhere else ? >> >> Abhinandan Prateek wrote:

Re: Review Request 12469: WIP: New implementation of LDAP authentication

2013-07-12 Thread Ian Duffy
> On July 12, 2013, 9:50 a.m., Abhinandan Prateek wrote: > > Ship It! > > Sebastien Goasguen wrote: > Abhi, I had already applied it to the ldapplugin branch. Did you apply > the patch somewhere else ? > > Abhinandan Prateek wrote: > No thats fine. I realised that after I have marked "

Re: Review Request 12469: WIP: New implementation of LDAP authentication

2013-07-12 Thread Abhinandan Prateek
> On July 12, 2013, 9:50 a.m., Abhinandan Prateek wrote: > > Ship It! > > Sebastien Goasguen wrote: > Abhi, I had already applied it to the ldapplugin branch. Did you apply > the patch somewhere else ? No thats fine. I realised that after I have marked "ship it". Maybe Ian can close this

Re: Review Request 12469: WIP: New implementation of LDAP authentication

2013-07-12 Thread Sebastien Goasguen
> On July 12, 2013, 9:50 a.m., Abhinandan Prateek wrote: > > Ship It! Abhi, I had already applied it to the ldapplugin branch. Did you apply the patch somewhere else ? - Sebastien --- This is an automatically generated e-mail. To reply

Re: Review Request 12469: WIP: New implementation of LDAP authentication

2013-07-12 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12469/#review23072 --- Ship it! Ship It! - Abhinandan Prateek On July 11, 2013, 1:32 p.

Re: Review Request 12469: WIP: New implementation of LDAP authentication

2013-07-11 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12469/#review23013 --- Ship it! applied to the ldapplugin branch thanks a lot, this is ter

Re: Review Request 12469: WIP: New implementation of LDAP authentication

2013-07-11 Thread Ian Duffy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12469/ --- (Updated July 11, 2013, 1:32 p.m.) Review request for cloudstack, Abhinandan Pr

Re: Review Request 12469: WIP: New implementation of LDAP authentication

2013-07-11 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12469/#review23010 --- Can you rebase to take into account recent changes of setup/db/db/s

Re: Review Request 12469: WIP: New implementation of LDAP authentication

2013-07-11 Thread Ian Duffy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12469/ --- (Updated July 11, 2013, 9:37 a.m.) Review request for cloudstack, Abhinandan Pr

Re: Review Request 12469: WIP: New implementation of LDAP authentication

2013-07-11 Thread Ian Duffy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12469/ --- (Updated July 11, 2013, 9:37 a.m.) Review request for cloudstack, Abhinandan Pr

Review Request 12469: WIP: New implementation of LDAP authentication

2013-07-11 Thread Ian Duffy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12469/ --- Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen. Bugs: