----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12469/ -----------------------------------------------------------
(Updated July 11, 2013, 9:37 a.m.) Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen. Changes ------- Fix slight issue I didn't notice before first upload. Bugs: CLOUDSTACK-2014 Repository: cloudstack-git Description ------- Adds a new implementation of the LDAP authenticator. This is a work in progress and has been placed here to show my progress within the GSoC program. Diffs ----- api/src/com/cloud/configuration/ConfigurationService.java 381fcad api/src/org/apache/cloudstack/api/ApiConstants.java dd876f7 api/src/org/apache/cloudstack/api/ResponseGenerator.java d8d07cb api/src/org/apache/cloudstack/api/command/admin/ldap/LDAPConfigCmd.java 38f58ec api/src/org/apache/cloudstack/api/command/admin/ldap/LDAPRemoveCmd.java 5159fba api/src/org/apache/cloudstack/api/response/LDAPConfigResponse.java bbeec63 api/src/org/apache/cloudstack/api/response/LDAPRemoveResponse.java 0feec5b client/tomcatconf/applicationContext.xml.in 14255c1 client/tomcatconf/commands.properties.in 6a38795 client/tomcatconf/componentContext.xml.in 1fbec61 client/tomcatconf/nonossComponentContext.xml.in ffa6281 client/tomcatconf/simulatorComponentContext.xml.in 92278a4 engine/storage/.gitignore PRE-CREATION plugins/api/rate-limit/src/org/apache/cloudstack/ratelimit/ApiRateLimitServiceImpl.java 7d1b43a plugins/user-authenticators/ldap/pom.xml 5c45f11 plugins/user-authenticators/ldap/src/com/cloud/server/auth/LDAPUserAuthenticator.java d928a5b plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapAddConfigurationCmd.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapDeleteConfigurationCmd.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListAllUsersCmd.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapUserSearchCmd.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfigurationVO.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManager.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUser.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUtils.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/NoLdapUserMatchingQueryException.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/NoSuchLdapUserException.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/dao/LdapConfigurationDao.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/dao/LdapConfigurationDaoImpl.java PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/BasicNamingEnumerationImpl.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapAddConfigurationCmdSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapAuthenticatorSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationDaoImplSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationResponseSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVO.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapContextFactorySpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapDeleteConfigurationCmdSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListAllUsersCmdSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListConfigurationCmdSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapManagerImplSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserManagerSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserResponseSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUtilsSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/NoLdapUserMatchingQueryExceptionSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/NoSuchLdapUserExceptionSpec.groovy PRE-CREATION server/src/com/cloud/api/ApiResponseHelper.java b56aa4a server/src/com/cloud/configuration/Config.java 1a2c620 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 2089f82 server/src/com/cloud/server/ManagementServerImpl.java 40bc437 server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 7a61978 setup/db/db/schema-410to420.sql 0c1d753 tools/apidoc/gen_toc.py 33a7e75 ui/scripts/globalSettings.js 1ae73b7 Diff: https://reviews.apache.org/r/12469/diff/ Testing ------- Unit tests have been wrote for the plugin and have 92% code coverage. The code successfully complies and I have done manual testing. That is, adding an LDAP server(Windows AD based and OpenLDAP based) configuring the credentials and attributes for it and testing a login. Updated integration tests will be submitted at stage in the future. Thanks, Ian Duffy
