Re: Review Request 11981: Adding base support for NVP security groups to the NVP API

2014-01-14 Thread David Nalley
On Tue, Jan 14, 2014 at 9:29 AM, Hugo Trippaers wrote: > > >> On Dec. 31, 2013, 2:35 a.m., Amogh Vasekar wrote: >> > Reminder - >> > >> > Hi, >> > This request has been pending for long. Please take the time to address >> > the comments raised. Thanks! > > This request can be marked as abandoned.

Re: Review Request 11981: Adding base support for NVP security groups to the NVP API

2014-01-14 Thread Hugo Trippaers
> On Dec. 31, 2013, 2:35 a.m., Amogh Vasekar wrote: > > Reminder - > > > > Hi, > > This request has been pending for long. Please take the time to address the > > comments raised. Thanks! This request can be marked as abandoned. - Hugo -

Re: Review Request 11981: Adding base support for NVP security groups to the NVP API

2013-12-30 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11981/#review30992 --- Reminder - Hi, This request has been pending for long. Please take

Re: Review Request 11981: Adding base support for NVP security groups to the NVP API

2013-11-21 Thread Amogh Vasekar
> On June 20, 2013, 6:40 a.m., Prasanna Santhanam wrote: > > Minor nitpick : our code conventions recommend the method naming to not use > > underscore. so it's lowerCaseAndNoUnderscores() > > > > http://cloudstack.apache.org/develop/coding-conventions.html > > Animesh Chaturvedi wrote: >

Re: Review Request 11981: Adding base support for NVP security groups to the NVP API

2013-09-26 Thread Chiradeep Vittal
> On June 20, 2013, 6:40 a.m., Prasanna Santhanam wrote: > > Minor nitpick : our code conventions recommend the method naming to not use > > underscore. so it's lowerCaseAndNoUnderscores() > > > > http://cloudstack.apache.org/develop/coding-conventions.html > > Animesh Chaturvedi wrote: >

Re: Review Request 11981: Adding base support for NVP security groups to the NVP API

2013-09-25 Thread Animesh Chaturvedi
> On June 20, 2013, 6:40 a.m., Prasanna Santhanam wrote: > > Minor nitpick : our code conventions recommend the method naming to not use > > underscore. so it's lowerCaseAndNoUnderscores() > > > > http://cloudstack.apache.org/develop/coding-conventions.html Hugo can you review this patch - A