----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11981/#review30992 -----------------------------------------------------------
Reminder - Hi, This request has been pending for long. Please take the time to address the comments raised. Thanks! - Amogh Vasekar On June 19, 2013, 9:28 p.m., Adrian Steer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11981/ > ----------------------------------------------------------- > > (Updated June 19, 2013, 9:28 p.m.) > > > Review request for cloudstack and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > This is initial version of API implementation of security groups within the > NVP API > > > Diffs > ----- > > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitchPort.java > c571458 > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraAddressPairs.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraLogicalPortRule.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java > 12fa6c0 > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraSecurityProfile.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/11981/diff/ > > > Testing > ------- > > Compile testing > > > Thanks, > > Adrian Steer > >