Re: Review Request: generalisation of network code (needed for CLOUDSTACK-1532)

2013-06-13 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10970/ --- (Updated June 13, 2013, 1:09 p.m.) Review request for cloudstack, Murali Reddy,

Re: Review Request: generalisation of network code (needed for CLOUDSTACK-1532)

2013-06-10 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10970/ --- (Updated June 10, 2013, 9:20 a.m.) Review request for cloudstack, Murali Reddy,

Re: Review Request: generalisation of network code (needed for CLOUDSTACK-1532)

2013-06-04 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10970/#review21417 --- plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/

Re: Review Request: generalisation of network code (needed for CLOUDSTACK-1532)

2013-05-30 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10970/ --- (Updated May 30, 2013, 11:58 a.m.) Review request for cloudstack, Murali Reddy,

Re: Review Request: generalisation of network code (needed for CLOUDSTACK-1532)

2013-05-30 Thread daan Hoogland
> On May 30, 2013, 8:56 a.m., Hugo Trippaers wrote: > > Daan, > > > > I noticed quite a few tabs in your patch. The CloudStack standard is to use > > spaces instead of tabs. Can you change the patch to fix this? > > > > Other comments below. > > > > Can you explain what tests you executed to

Re: Review Request: generalisation of network code (needed for CLOUDSTACK-1532)

2013-05-30 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10970/#review21191 --- Daan, I noticed quite a few tabs in your patch. The CloudStack stan

Re: Review Request: generalisation of network code (needed for CLOUDSTACK-1532)

2013-05-28 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10970/ --- (Updated May 28, 2013, 9:43 a.m.) Review request for cloudstack, Murali Reddy,

Re: Review Request: generalisation of network code (needed for CLOUDSTACK-1532)

2013-05-28 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10970/ --- (Updated May 28, 2013, 9:29 a.m.) Review request for cloudstack, Murali Reddy a

Re: Review Request: generalisation of network code (needed for CLOUDSTACK-1532)

2013-05-22 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10970/ --- (Updated May 22, 2013, 11:21 a.m.) Review request for cloudstack, Murali Reddy

Re: Review Request: generalisation of network code (needed for CLOUDSTACK-1532)

2013-05-09 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10970/ --- (Updated May 9, 2013, 1:02 p.m.) Review request for cloudstack. Changes -

Re: Review Request: generalisation of network code (needed for CLOUDSTACK-1532)

2013-05-08 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10970/ --- (Updated May 8, 2013, 11:09 a.m.) Review request for cloudstack. Changes

Re: Review Request: generalisation of network code (needed for CLOUDSTACK-1532)

2013-05-07 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10970/ --- (Updated May 7, 2013, 1:33 p.m.) Review request for cloudstack. Description -

Review Request: generalisation of network code (needed for CLOUDSTACK-1532)

2013-05-07 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10970/ --- Review request for cloudstack. Description --- converting vlan id to uri t