----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10970/ -----------------------------------------------------------
(Updated May 9, 2013, 1:02 p.m.) Review request for cloudstack. Changes ------- new diff file with some ommisions added Description ------- converting vlan id to uri to support a broader range of networks in for instance vpc gateway connections Diffs (updated) ----- api/src/com/cloud/agent/api/to/IpAddressTO.java 82c7d99 api/src/com/cloud/agent/api/to/NetworkTO.java 3edd4c0 api/src/com/cloud/network/NetworkService.java 5d4fd67 api/src/com/cloud/network/Networks.java f085e9f api/src/com/cloud/network/vpc/PrivateIp.java eb68433 api/src/com/cloud/network/vpc/StaticRouteProfile.java 54aa6e4 api/src/com/cloud/network/vpc/VpcGateway.java e3530d0 api/src/com/cloud/network/vpc/VpcService.java 23e2764 api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 2055695 api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java ca76062 api/test/com/cloud/agent/api/to/NetworkTOTest.java PRE-CREATION core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46 plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java 6d14e3f plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java b897df2 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java 37761aa plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java a626e31 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 030eff0 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java a16733b plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java 1733712 plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java a0068c3 plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java 98e1461 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac server/src/com/cloud/api/ApiResponseHelper.java d7eaa26 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 37ca793 server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 4a90a77 server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java 686f5bc server/src/com/cloud/network/ExternalLoadBalancerUsageManagerImpl.java d405382 server/src/com/cloud/network/NetworkManager.java 4af716c server/src/com/cloud/network/NetworkManagerImpl.java 4fffbc1 server/src/com/cloud/network/NetworkServiceImpl.java 5e8be92 server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java cf27986 server/src/com/cloud/network/guru/PrivateNetworkGuru.java 2e266e7 server/src/com/cloud/network/guru/PublicNetworkGuru.java a83cdb3 server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java ebf2d42 server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db server/src/com/cloud/network/vpc/PrivateIpAddress.java 2f3cf53 server/src/com/cloud/network/vpc/VpcManagerImpl.java a7f06e9 server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION server/test/com/cloud/network/MockNetworkManagerImpl.java 2f717c8 server/test/com/cloud/vpc/MockNetworkManagerImpl.java f884ba1 server/test/com/cloud/vpc/MockVpcManagerImpl.java baccbd0 setup/db/db/schema-410to420.sql c8ac1ec Diff: https://reviews.apache.org/r/10970/diff/ Testing (updated) ------- the NetworkTO is tested to accept uris with several initial states. createPrivateNetwork in NetworkServiceImpl is tested (to accpet only vlan based networks for now) Thanks, daan Hoogland
