Re: Review Request: Fix for CLOUDSTACK-1987

2013-04-12 Thread Min Chen
I will provide a patch for 1987 today. Thanks -min On 4/12/13 6:06 AM, "Chip Childers" wrote: >On Fri, Apr 12, 2013 at 05:38:28AM +, Min Chen wrote: >> >> >> > On April 12, 2013, 5:28 a.m., Min Chen wrote: >> > > server/src/com/cloud/api/query/QueryManagerImpl.java, line 2111 >> > > >>

Re: Review Request: Fix for CLOUDSTACK-1987

2013-04-12 Thread Chip Childers
On Fri, Apr 12, 2013 at 05:38:28AM +, Min Chen wrote: > > > > On April 12, 2013, 5:28 a.m., Min Chen wrote: > > > server/src/com/cloud/api/query/QueryManagerImpl.java, line 2111 > > > > > > > > > For domain users,

Re: Review Request: Fix for CLOUDSTACK-1987

2013-04-11 Thread Min Chen
> On April 12, 2013, 5:28 a.m., Min Chen wrote: > > server/src/com/cloud/api/query/QueryManagerImpl.java, line 2111 > > > > > > For domain users, they should not be able to query system offerings. > > This fix didn't

Re: Review Request: Fix for CLOUDSTACK-1987

2013-04-11 Thread Min Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10426/#review19052 --- server/src/com/cloud/api/query/QueryManagerImpl.java

Re: Review Request: Fix for CLOUDSTACK-1987

2013-04-11 Thread Min Chen
So your patch is to fix 1989, right? -min Sent from my iPhone On Apr 11, 2013, at 9:56 PM, "Marcus Sorensen" mailto:shadow...@gmail.com>> wrote: Adding list, it looks like reviews.apache.org left it off (due to the group field being empty?). On Thu, Apr 11, 2013 a

Re: Review Request: Fix for CLOUDSTACK-1987

2013-04-11 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10426/ --- (Updated April 12, 2013, 4:57 a.m.) Review request for cloudstack, Chip Childer

Re: Review Request: Fix for CLOUDSTACK-1987

2013-04-11 Thread Marcus Sorensen
Adding list, it looks like reviews.apache.org left it off (due to the group field being empty?). On Thu, Apr 11, 2013 at 10:53 PM, Marcus Sorensen wrote: > There were two issues, one is that service offerings that have been > deleted show up as available from a domain user's perspective (but no