----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10426/#review19052 -----------------------------------------------------------
server/src/com/cloud/api/query/QueryManagerImpl.java <https://reviews.apache.org/r/10426/#comment39602> For domain users, they should not be able to query system offerings. This fix didn't guard that case. - Min Chen On April 12, 2013, 4:57 a.m., Ryan Dietrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10426/ > ----------------------------------------------------------- > > (Updated April 12, 2013, 4:57 a.m.) > > > Review request for cloudstack, Chip Childers and Marcus Sorensen. > > > Description > ------- > > So, without this fix you can't query service offerings that don't have a > domain id set (null). > > > Diffs > ----- > > server/src/com/cloud/api/query/QueryManagerImpl.java 951d09e > > Diff: https://reviews.apache.org/r/10426/diff/ > > > Testing > ------- > > Called "listServiceOfferings" using a simple perl script, once with an ID, > and once without an ID specified. > > > Thanks, > > Ryan Dietrich > >
