Re: Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support

2013-05-07 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10836/#review20292 --- Commit b6cb23cb99c9daee41b46a3fc13fffabfb791dc3 in branch refs/heads

Re: Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support

2013-05-07 Thread Sanjay Tripathi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10836/ --- (Updated May 7, 2013, 8:06 a.m.) Review request for cloudstack, Devdeep Singh,

Re: Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support

2013-05-06 Thread Fang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10836/#review20209 --- Ship it! Ship it! - Fang Wang On April 29, 2013, 9:09 a.m., Sanj

Re: Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support

2013-05-03 Thread Sanjay Tripathi
> On May 3, 2013, 6:50 p.m., Fang Wang wrote: > > In file ajaxkeys.js, the original lines 32-33, and 47-49 are deleted. Those > > are needed for handling the JP keyboards. Did you replace them with other > > key combinations? just make sure it won't break the JP keyboards. > > > > Thanks. Fan

Re: Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support

2013-05-03 Thread Fang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10836/#review20130 --- In file ajaxkeys.js, the original lines 32-33, and 47-49 are deleted

Re: Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support

2013-05-01 Thread Devdeep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10836/#review20055 --- I don't understand this code completely and I may not be the right p

Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support

2013-04-29 Thread Sanjay Tripathi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10836/ --- Review request for cloudstack, Devdeep Singh, Fang Wang, and Animesh Chaturvedi.