----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10836/#review20130 -----------------------------------------------------------
In file ajaxkeys.js, the original lines 32-33, and 47-49 are deleted. Those are needed for handling the JP keyboards. Did you replace them with other key combinations? just make sure it won't break the JP keyboards. Thanks. - Fang Wang On April 29, 2013, 9:09 a.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10836/ > ----------------------------------------------------------- > > (Updated April 29, 2013, 9:09 a.m.) > > > Review request for cloudstack, Devdeep Singh, Fang Wang, and Animesh > Chaturvedi. > > > Description > ------- > > CLOUDSTACK-957: Localization -- Add UK keyboard support. > > - Added the support of UK keyboard by: > - Initialising the UK keyboard from the existing US keyboard mapping. > - Adding/Overriding the special keys support of UK keys which differ > from US keyboard. > - Also moved the JP keys initialisation to ajaxkeys.js file. > > > This addresses bug CLOUDSTACK-957. > > > Diffs > ----- > > services/console-proxy/server/css/ajaxviewer.css 5ea552b > services/console-proxy/server/js/ajaxkeys.js 2ecf5b5 > services/console-proxy/server/js/ajaxviewer.js e95615d > > services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java > 289bdab > > Diff: https://reviews.apache.org/r/10836/diff/ > > > Testing > ------- > > Tests: > > 1) Setup CS environment and deploy a VM (Windows7 preferred, as I have tested > on this). > 2) Go to VM detailView and open VM console view. > 3) Change input method for keyboard to UK language. > 4) Go to top of console-window and click on "keyboard" option to select UK > language. > 5) Start using UK keyboard (Make sure the input method of client keyboard is > UK (from where the user is pressing the keys)). > > Tested on my local CloudStack setup by following above mentioned steps. > > > Thanks, > > Sanjay Tripathi > >
