Re: Review Request: CLOUDSTACK-1871 : domainId parameter to uploadVolume not working

2013-05-19 Thread Isaac Chiang
> On May 17, 2013, 9:12 a.m., Devdeep Singh wrote: > > Ship It! > > Devdeep Singh wrote: > Changes look fine. Issac, since you are committer, you can push these > changes yourself :). Thanks :) - Isaac --- This is an automatically

Re: Review Request: CLOUDSTACK-1871 : domainId parameter to uploadVolume not working

2013-05-19 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10479/#review20744 --- Commit 63e92a4ea6766212d4450cde3cf205d661a6419d in branch refs/heads

Re: Review Request: CLOUDSTACK-1871 : domainId parameter to uploadVolume not working

2013-05-17 Thread Devdeep Singh
> On May 17, 2013, 9:12 a.m., Devdeep Singh wrote: > > Ship It! Changes look fine. Issac, since you are committer, you can push these changes yourself :). - Devdeep --- This is an automatically generated e-mail. To reply, visit: https:

Re: Review Request: CLOUDSTACK-1871 : domainId parameter to uploadVolume not working

2013-05-17 Thread Devdeep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10479/#review20695 --- Ship it! Ship It! - Devdeep Singh On May 4, 2013, 1:37 p.m., Isa

Re: Review Request: CLOUDSTACK-1871 : domainId parameter to uploadVolume not working

2013-05-04 Thread Isaac Chiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10479/ --- (Updated May 4, 2013, 1:37 p.m.) Review request for cloudstack, Devdeep Singh a

Re: Review Request: CLOUDSTACK-1871 : domainId parameter to uploadVolume not working

2013-05-04 Thread Pranav Saxena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10479/#review20161 --- The logic looks good to me . But I'll still request someone in the c

Review Request: CLOUDSTACK-1871 : domainId parameter to uploadVolume not working

2013-04-15 Thread Isaac Chiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10479/ --- Review request for cloudstack and Pranav Saxena. Description --- CLOUDSTAC