----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10479/#review20161 -----------------------------------------------------------
The logic looks good to me . But I'll still request someone in the community who is more thorough with the backend code to review it once. If possible , Could you add Nitin Mehta or Devdeep Singh in the list of reviewers as well ? Thanks ! - Pranav Saxena On April 15, 2013, 4:17 p.m., Isaac Chiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10479/ > ----------------------------------------------------------- > > (Updated April 15, 2013, 4:17 p.m.) > > > Review request for cloudstack and Pranav Saxena. > > > Description > ------- > > CLOUDSTACK-1871 : domainId parameter to uploadVolume not working > > 1. Remove duplicated lines for setting domainId. > 2. Set domainId with owner's domain if the owner is specified ( with account > and domainid passed in) > > > This addresses bug CLOUDSTACK-1871. > > > Diffs > ----- > > server/src/com/cloud/storage/VolumeManagerImpl.java 1e8edaf > > Diff: https://reviews.apache.org/r/10479/diff/ > > > Testing > ------- > > Test from UI and curl request, both work well > > > Thanks, > > Isaac Chiang > >
