; Abhinandan Prateek
Subject: Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC
network is not getting IP
After talking with Daan, we decided to revert the commit for now. After Bharat
complete the rewrite of dnsmasqconfigurator in bash script. A new patch would
be committed to fix
After talking with Daan, we decided to revert the commit for now. After
Bharat complete the rewrite of dnsmasqconfigurator in bash script. A new
patch would be committed to fix CLOUDSTACK-3357 before the code freeze,
--Sheng
On Sun, Jul 21, 2013 at 9:52 AM, Sheng Yang wrote:
> And it's also my
I've got into at least two exceptions lately. They made me skeptic.
--Sheng
On Sun, Jul 21, 2013 at 10:38 AM, David Nalley wrote:
> On Sun, Jul 21, 2013 at 12:52 PM, Sheng Yang wrote:
> > And it's also my fault on this issue because I didn't look at the patch
> > when it's in reviewboard. I wa
On Sun, Jul 21, 2013 at 12:52 PM, Sheng Yang wrote:
> And it's also my fault on this issue because I didn't look at the patch
> when it's in reviewboard. I was not that diligent at reviewboard before...
>
> To prevent the same thing happen again, we may want to do something like
> xxx area's code
And it's also my fault on this issue because I didn't look at the patch
when it's in reviewboard. I was not that diligent at reviewboard before...
To prevent the same thing happen again, we may want to do something like
xxx area's code need to be reviewed by xxx, xxx, xxx in the future?
--Sheng
Sorry, the integration test of VPC has been failed for quite some time, I
just found this issue after fixing some other issues in the integration
test...
--Sheng
On Sun, Jul 21, 2013 at 9:23 AM, Daan Hoogland wrote:
> I am happy to redo the work with a different approach, but it did not break
>
I am happy to redo the work with a different approach, but it did not break
integration last week, did it? So a newer patch needs to be reverted, no?
The problem might be cumulative due to more then one commit, in which case
a role forward might be the quickest way to go.
On Sun, Jul 21, 2013 at
In fact DnsMasqConfigurator has other issues since it would complete
override the whole configuration file modified by bash scripts in the VR.
So Bharat is working on that and should send out patch soon, using bash
scripts on the dnsmasq.conf instead. Also that's our preferred approach to
modify dn
So if I understand your mail correctly, a VpcDnsMasqConfigurator should be
created to be used in configDnsMasq in VpcVirtualApplienceManagerImpl,
instead of the one used now?
On Sun, Jul 21, 2013 at 6:01 PM, Sheng Yang wrote:
> Hi Daan,
>
> We're talking about vpc router. Your patch affect the
On Sun, Jul 21, 2013 at 4:10 AM, Daan Hoogland wrote:
> please se inline comments
>
> On Sun, Jul 21, 2013 at 12:49 PM, Daan Hoogland >wrote:
>
> > H Sheng et al,
> >
> > I have no overview of what effect my patch has on guest vm's. It is
> > supposed to only generate a dnsmasq.conf for vpc-route
Hi Daan,
We're talking about vpc router. Your patch affect the guest vm because
guest VM cannot get ip address from VPC router(DHCP request fail).
The VPC indeed using a different dnsmasq.conf. See
/etc/vpcdnsmasq.conf(which is a template of VPC used dnsmasq).
You're using DnsMasqConfigurator, w
please se inline comments
On Sun, Jul 21, 2013 at 12:49 PM, Daan Hoogland wrote:
> H Sheng et al,
>
> I have no overview of what effect my patch has on guest vm's. It is
> supposed to only generate a dnsmasq.conf for vpc-router-vm's. not
> guestnetwork-vm's. I am happy to look at it, but have no
H Sheng et al,
I have no overview of what effect my patch has on guest vm's. It is
supposed to only generate a dnsmasq.conf for vpc-router-vm's. not
guestnetwork-vm's. I am happy to look at it, but have no overview of the
issue yet. Should a sepperate dnsmasq.conf instance be created for vpc
route
Add Daan's gmail.
--Sheng
On Fri, Jul 19, 2013 at 6:32 PM, Sheng Yang wrote:
> Daan, I've checked the code, the issue is, original code Bharat
> wrote(generated dnsmasq.conf) cannot deal with VPC. e.g. the VPC router
> wouldn't listen on eth0 and eth1, but non-vpc router wouldn't listen on
> e
Daan, I've checked the code, the issue is, original code Bharat
wrote(generated dnsmasq.conf) cannot deal with VPC. e.g. the VPC router
wouldn't listen on eth0 and eth1, but non-vpc router wouldn't listen on
eth1 and eth2. Also, some detail configurations of VPC are written into
/etc/dnsmasq.d/clou
Daan,
Bharat thinks your fix caused a block bug
https://issues.apache.org/jira/browse/CLOUDSTACK-3589? Could you check it?
--Sheng
On Thu, Jul 18, 2013 at 9:52 AM, Bharat Kumar wrote:
> Hi Dann,
>
> The bug fix
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=b903262df5
16 matches
Mail list logo
