Re: unused private methods in VirtualMachinManagerImpl

2014-06-12 Thread Mike Tutkowski
Thanks! On Thu, Jun 12, 2014 at 5:32 PM, Kelven Yang wrote: > Yes. I¹ll create an annotation > > Kelven > > On 6/11/14, 9:59 AM, "Mike Tutkowski" > wrote: > > >Yeah, and when a tool like Eclipse says a private variable is not in use, > >I > >can easily see someone removing it. > > > >So, does

Re: unused private methods in VirtualMachinManagerImpl

2014-06-12 Thread Kelven Yang
Yes. I¹ll create an annotation Kelven On 6/11/14, 9:59 AM, "Mike Tutkowski" wrote: >Yeah, and when a tool like Eclipse says a private variable is not in use, >I >can easily see someone removing it. > >So, does that mean you will create such an annotation, Kelven? :) > > >On Wed, Jun 11, 2014 at

Re: unused private methods in VirtualMachinManagerImpl

2014-06-11 Thread Mike Tutkowski
Yeah, and when a tool like Eclipse says a private variable is not in use, I can easily see someone removing it. So, does that mean you will create such an annotation, Kelven? :) On Wed, Jun 11, 2014 at 10:52 AM, Kelven Yang wrote: > I guess we can create one. Currently available annotations th

Re: unused private methods in VirtualMachinManagerImpl

2014-06-11 Thread Kelven Yang
I guess we can create one. Currently available annotations that are to be applied to java code are as following * @Override * @Deprecated * @SuppressWarnings * @SafeVarargs(since Java 7) * @FunctionalInterface(since Java 8) Calling functions through reflection is not a common way for static typi

Re: unused private methods in VirtualMachinManagerImpl

2014-06-11 Thread Mike Tutkowski
I am not aware of any existing annotation for that purpose (not that that means it doesn't necessary exist). Kelven - Do you know of one? If not, would you be willing to create one? Thanks! On Wed, Jun 11, 2014 at 2:06 AM, Daan Hoogland wrote: > is there one availible or are we implementing @

Re: unused private methods in VirtualMachinManagerImpl

2014-06-11 Thread Daan Hoogland
is there one availible or are we implementing @usedPrivate ? On Wed, Jun 11, 2014 at 2:54 AM, Mike Tutkowski wrote: > Good idea > > On Tuesday, June 10, 2014, Kelven Yang wrote: > >> Maybe utilizing special java annotation would get developer heads-up? >> Content in comments text is easily skipp

Re: unused private methods in VirtualMachinManagerImpl

2014-06-10 Thread Mike Tutkowski
Good idea On Tuesday, June 10, 2014, Kelven Yang wrote: > Maybe utilizing special java annotation would get developer heads-up? > Content in comments text is easily skipped as it is not usually considered > as mandatory language constructs > > Kelven > > On 6/10/14, 4:25 PM, "Mike Tutkowski" >

Re: unused private methods in VirtualMachinManagerImpl

2014-06-10 Thread Kelven Yang
Maybe utilizing special java annotation would get developer heads-up? Content in comments text is easily skipped as it is not usually considered as mandatory language constructs Kelven On 6/10/14, 4:25 PM, "Mike Tutkowski" wrote: >I haven't looked, but perhaps we should provide sufficient co

Re: unused private methods in VirtualMachinManagerImpl

2014-06-10 Thread Mike Tutkowski
I haven't looked, but perhaps we should provide sufficient comments in each of these cases so no one removes the fields thinking that they are old and no longer in use. On Tue, Jun 10, 2014 at 5:13 PM, Kelven Yang wrote: > The usage of these private methods are through reflection, making it > p

Re: unused private methods in VirtualMachinManagerImpl

2014-06-10 Thread Kelven Yang
The usage of these private methods are through reflection, making it private is to avoid exposing unnecessary internal structures to outside. Kelven On 6/10/14, 2:46 AM, "Rajani Karuturi" wrote: >Hi Kelven, >while fixing some of the issues reported by coverity I encountered some >unused private