I am not aware of any existing annotation for that purpose (not that that means it doesn't necessary exist).
Kelven - Do you know of one? If not, would you be willing to create one? Thanks! On Wed, Jun 11, 2014 at 2:06 AM, Daan Hoogland <daan.hoogl...@gmail.com> wrote: > is there one availible or are we implementing @usedPrivate ? > > On Wed, Jun 11, 2014 at 2:54 AM, Mike Tutkowski > <mike.tutkow...@solidfire.com> wrote: > > Good idea > > > > On Tuesday, June 10, 2014, Kelven Yang <kelven.y...@citrix.com> wrote: > > > >> Maybe utilizing special java annotation would get developer heads-up? > >> Content in comments text is easily skipped as it is not usually > considered > >> as mandatory language constructs > >> > >> Kelven > >> > >> On 6/10/14, 4:25 PM, "Mike Tutkowski" <mike.tutkow...@solidfire.com> > >> wrote: > >> > >> >I haven't looked, but perhaps we should provide sufficient comments in > >> >each > >> >of these cases so no one removes the fields thinking that they are old > and > >> >no longer in use. > >> > > >> > > >> >On Tue, Jun 10, 2014 at 5:13 PM, Kelven Yang <kelven.y...@citrix.com> > >> >wrote: > >> > > >> >> The usage of these private methods are through reflection, making it > >> >> private is to avoid exposing unnecessary internal structures to > outside. > >> >> > >> >> Kelven > >> >> > >> >> On 6/10/14, 2:46 AM, "Rajani Karuturi" <rajani.karut...@citrix.com> > >> >>wrote: > >> >> > >> >> >Hi Kelven, > >> >> >while fixing some of the issues reported by coverity I encountered > some > >> >> >unused private methods in VirtualMachineManagerImpl.java > >> >> >(https://reviews.apache.org/r/22364 ) and removed them. Koushik > >> pointed > >> >> >that they are getting used by the job framework. > >> >> >Looks like these are used by the job framework by making them public > >> >> >through reflection and following some convention for the function > >> >>names. > >> >> > > >> >> >Its very difficult to find the usages or refactor which can have > some > >> >> >unforeseen consequences. > >> >> > > >> >> >Can you share some details about them? probably some javadoc? > >> >> > > >> >> > > >> >> >~Rajani > >> >> > > >> >> > > >> >> > > >> >> >On 10-Jun-2014, at 12:37 pm, Koushik Das <koushik....@citrix.com> > >> >>wrote: > >> >> > > >> >> >> > >> >> >> ----------------------------------------------------------- > >> >> >> This is an automatically generated e-mail. To reply, visit: > >> >> >> https://reviews.apache.org/r/22364/#review45200 > >> >> >> ----------------------------------------------------------- > >> >> >> > >> >> >> > >> >> >> > >> >> >> > engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java > >> >> >> <https://reviews.apache.org/r/22364/#comment79921> > >> >> >> > >> >> >> These methods are getting used by the job framework. Check > >> >> >>handleVmWorkJob() method in the same java file. > >> >> >> > >> >> >> > >> >> >> - Koushik Das > >> >> >> > >> >> >> > >> >> >> On June 10, 2014, 4:06 a.m., Rajani Karuturi wrote: > >> >> >>> > >> >> >>> ----------------------------------------------------------- > >> >> >>> This is an automatically generated e-mail. To reply, visit: > >> >> >>> https://reviews.apache.org/r/22364/ > >> >> >>> ----------------------------------------------------------- > >> >> >>> > >> >> >>> (Updated June 10, 2014, 4:06 a.m.) > >> >> >>> > >> >> >>> > >> >> >>> Review request for cloudstack, daan Hoogland, Kelven Yang, > Koushik > >> >> >>>Das, and Santhosh Edukulla. > >> >> >>> > >> >> >>> > >> >> >>> Repository: cloudstack-git > >> >> >>> > >> >> >>> > >> >> >>> Description > >> >> >>> ------- > >> >> >>> > >> >> >>> NPEs, unused code or dead code, unwritten field access and self > >> >> >>>assignment > >> >> >>> > >> >> >>> > >> >> >>> Diffs > >> >> >>> ----- > >> >> >>> > >> >> >>> > >> >>engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java > >> >> >>>25c67db > >> >> >>> > >> >> >>> Diff: https://reviews.apache.org/r/22364/diff/ > >> >>*Mike Tutkowski* > >> >*Senior CloudStack Developer, SolidFire Inc.* > >> >e: mike.tutkow...@solidfire.com <javascript:;> > >> >o: 303.746.7302 > >> >Advancing the way the world uses the cloud > >> ><http://solidfire.com/solution/overview/?video=play>* * > >> > >> > > > > -- > > *Mike Tutkowski* > > *Senior CloudStack Developer, SolidFire Inc.* > > e: mike.tutkow...@solidfire.com > > o: 303.746.7302 > > Advancing the way the world uses the cloud > > <http://solidfire.com/solution/overview/?video=play>*™* > > > > -- > Daan > -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud <http://solidfire.com/solution/overview/?video=play>*™*
