Re: easy bug to fix for new comer

2013-06-21 Thread Chip Childers
On Fri, Jun 21, 2013 at 03:28:48PM +0200, Daan Hoogland wrote: > five files to go. I may finish it on the plane or else next week. Very productive week for you! Thanks Daan.

Re: easy bug to fix for new comer

2013-06-21 Thread Daan Hoogland
five files to go. I may finish it on the plane or else next week. On Fri, Jun 21, 2013 at 11:12 AM, Daan Hoogland wrote: > I submitted a biggy. please review this and consider whether pep8 is > beating the purpose of formatting. Espacially line length of 80 seems not > what you want. You'll want

Re: easy bug to fix for new comer

2013-06-21 Thread Daan Hoogland
I submitted a biggy. please review this and consider whether pep8 is beating the purpose of formatting. Espacially line length of 80 seems not what you want. You'll want your terminals show more character then that in this century. On Fri, Jun 21, 2013 at 10:07 AM, Prasanna Santhanam wrote: > Y

Re: easy bug to fix for new comer

2013-06-21 Thread Prasanna Santhanam
Yup - please skip that too. On Fri, Jun 21, 2013 at 09:56:47AM +0200, Daan Hoogland wrote: > how about sandbox? It doesn't sound like really long term strategic code > either. > > > On Fri, Jun 21, 2013 at 8:02 AM, Prasanna Santhanam wrote: > > > One other thing: You can skip pep8-ing the inte

Re: easy bug to fix for new comer

2013-06-21 Thread Daan Hoogland
how about sandbox? It doesn't sound like really long term strategic code either. On Fri, Jun 21, 2013 at 8:02 AM, Prasanna Santhanam wrote: > One other thing: You can skip pep8-ing the integration module since > that will be deprecated in the future. There's a lot of classes in > there so it'll

Re: easy bug to fix for new comer

2013-06-20 Thread Prasanna Santhanam
ithPython- [2] http://jenkins.buildacloud.org/view/cloudstack-qa/job/test-smoke-matrix/ Thanks for the patches! > > -Original Message- > From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] > Sent: donderdag 20 juni 2013 15:43 > To: 'dev@cloudstack.apache.org' > Subje

Re: easy bug to fix for new comer

2013-06-20 Thread Prasanna Santhanam
One other thing: You can skip pep8-ing the integration module since that will be deprecated in the future. There's a lot of classes in there so it'll save you time. On Thu, Jun 20, 2013 at 01:04:55PM -0400, Sebastien Goasguen wrote: > Daan, > > Your patches applied cleanly and have been committed

Re: easy bug to fix for new comer

2013-06-20 Thread daan.hoogland
My karma is fine. I overlooked this detail Verzonden vanaf mobiel Oorspronkelijk bericht Van: Sebastien Goasguen Datum: 2013-06-20 19:05 (GMT+01:00) Aan: dev@cloudstack.apache.org Onderwerp: Re: easy bug to fix for new comer Daan, also assign the bug to yourself in

Re: easy bug to fix for new comer

2013-06-20 Thread Sebastien Goasguen
es now >> >> >> On Jun 20, 2013, at 10:54 AM, Daan Hoogland >> wrote: >> >>> Halting now, will take on the bigger ones tonight/-morow >>> >>> -Original Message- >>> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]

Re: easy bug to fix for new comer

2013-06-20 Thread Sebastien Goasguen
] >> Sent: donderdag 20 juni 2013 16:12 >> To: 'dev@cloudstack.apache.org' >> Subject: RE: easy bug to fix for new comer >> >> I noticed some are very small. Doing those first and I am still doing them >> one file at a time! >> >> -Original Messa

Re: easy bug to fix for new comer

2013-06-20 Thread Sebastien Goasguen
6:12 > To: 'dev@cloudstack.apache.org' > Subject: RE: easy bug to fix for new comer > > I noticed some are very small. Doing those first and I am still doing them > one file at a time! > > -Original Message- > From: Prasanna Santhanam [mailto:t...@apache.org

RE: easy bug to fix for new comer

2013-06-20 Thread Daan Hoogland
Halting now, will take on the bigger ones tonight/-morow -Original Message- From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] Sent: donderdag 20 juni 2013 16:12 To: 'dev@cloudstack.apache.org' Subject: RE: easy bug to fix for new comer I noticed some are very small. D

RE: easy bug to fix for new comer

2013-06-20 Thread Daan Hoogland
I noticed some are very small. Doing those first and I am still doing them one file at a time! -Original Message- From: Prasanna Santhanam [mailto:t...@apache.org] Sent: donderdag 20 juni 2013 16:02 To: dev@cloudstack.apache.org Subject: Re: easy bug to fix for new comer

RE: easy bug to fix for new comer

2013-06-20 Thread Daan Hoogland
Btw Sebastien, Newcomer as I am; how do I test the test-code tests? -Original Message- From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] Sent: donderdag 20 juni 2013 15:43 To: 'dev@cloudstack.apache.org' Subject: RE: easy bug to fix for new comer Sure, One file

Re: easy bug to fix for new comer

2013-06-20 Thread Prasanna Santhanam
cloudstackConnection was pep8 compliant but seems to have flouted it again. I'll look at setting up a jenkins job for style check when the full pep8 compliance is done. On Thu, Jun 20, 2013 at 01:42:36PM +, Daan Hoogland wrote: > Sure, > > One file at a time! > > -Original Message- >

RE: easy bug to fix for new comer

2013-06-20 Thread Daan Hoogland
Sure, One file at a time! -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: donderdag 20 juni 2013 14:35 To: dev@cloudstack.apache.org Subject: easy bug to fix for new comer Hi, Here is an easy bug to fix for a newcomer to cloudstack: https://issues.apache.or