Re: Unfamiliar with checkstyle

2014-01-09 Thread Mike Tutkowski
; Sent: Thursday, January 9, 2014 3:39 PM > > To: dev@cloudstack.apache.org > > Subject: Re: Unfamiliar with checkstyle > > > > Worst case, I should just be able to copy/paste from what's already in > master, > > but I was curious about the error message it

RE: Unfamiliar with checkstyle

2014-01-09 Thread Alex Huang
Sent: Thursday, January 9, 2014 3:39 PM > To: dev@cloudstack.apache.org > Subject: Re: Unfamiliar with checkstyle > > Worst case, I should just be able to copy/paste from what's already in master, > but I was curious about the error message itself. > > > On Thu, Jan 9,

Re: Unfamiliar with checkstyle

2014-01-09 Thread Mike Tutkowski
mail >>>> that the merge brought back in a few imports that checkstyle did not like. >>>> >>>> Thanks! >>>> >>>> >>>> On Thu, Jan 9, 2014 at 2:47 PM, Alex Huang wrote: >>>> >>>>> Mike, >>&

Re: Unfamiliar with checkstyle

2014-01-09 Thread Mike Tutkowski
> On Thu, Jan 9, 2014 at 2:47 PM, Alex Huang wrote: >>> >>>> Mike, >>>> >>>> My guess is it's been brought back in during the merge. I fixed most >>>> of those things in master. You can go back to a previous version to double >>>>

Re: Unfamiliar with checkstyle

2014-01-09 Thread Mike Tutkowski
sabled it. >>> >>> --Alex >>> >>> > -Original Message- >>> > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] >>> > Sent: Thursday, January 9, 2014 1:05 PM >>> > To: dev@cloudstack.apache.org >>>

Re: Unfamiliar with checkstyle

2014-01-09 Thread Mike Tutkowski
t; >> Checkstyle is being run for every single project, unless someone >> specifically disabled it. >> >> --Alex >> >> > -Original Message- >> > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] >> > Sent: Thursday, January 9, 2014 1

Re: Unfamiliar with checkstyle

2014-01-09 Thread Mike Tutkowski
o:mike.tutkow...@solidfire.com] > > Sent: Thursday, January 9, 2014 1:05 PM > > To: dev@cloudstack.apache.org > > Subject: Re: Unfamiliar with checkstyle > > > > I see two of the issues are in CloudStackPrimaryDataStoreImpl and are > > related to imports. >

RE: Unfamiliar with checkstyle

2014-01-09 Thread Alex Huang
Message- > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] > Sent: Thursday, January 9, 2014 1:05 PM > To: dev@cloudstack.apache.org > Subject: Re: Unfamiliar with checkstyle > > I see two of the issues are in CloudStackPrimaryDataStoreImpl and are > related to imports. &

Re: Unfamiliar with checkstyle

2014-01-09 Thread Mike Tutkowski
I see two of the issues are in CloudStackPrimaryDataStoreImpl and are related to imports. One complains about using * and the other about having duplicate imports. I did not actually make these changes, so this makes me wonder if checkstyle is not typically being run on every project (so maybe I

Re: Unfamiliar with checkstyle

2014-01-09 Thread Mike Tutkowski
It looks like we need to apply the checkstyle rules on a project-by-project basis. Are we currently applying these rules to every project or just a subset? Thanks On Thu, Jan 9, 2014 at 1:04 PM, Mike Tutkowski wrote: > I can install the plug-in for Eclipse. > > Thanks, Alex! > > > On Thu, Jan

Re: Unfamiliar with checkstyle

2014-01-09 Thread Mike Tutkowski
I can install the plug-in for Eclipse. Thanks, Alex! On Thu, Jan 9, 2014 at 11:34 AM, Alex Huang wrote: > Mike, > > If you're using eclipse, checkstyle has a plugin that you can install. > Point the plugin to the style file in tools/checkstyle/cloud-style.xml and > it will use the same syntax

RE: Unfamiliar with checkstyle

2014-01-09 Thread Alex Huang
Mike, If you're using eclipse, checkstyle has a plugin that you can install. Point the plugin to the style file in tools/checkstyle/cloud-style.xml and it will use the same syntax. I've always found it much easier to use the plugin than to read the build outputs. If you don't want to install