Mike, My guess is it's been brought back in during the merge. I fixed most of those things in master. You can go back to a previous version to double check.
Checkstyle is being run for every single project, unless someone specifically disabled it. --Alex > -----Original Message----- > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] > Sent: Thursday, January 9, 2014 1:05 PM > To: dev@cloudstack.apache.org > Subject: Re: Unfamiliar with checkstyle > > I see two of the issues are in CloudStackPrimaryDataStoreImpl and are > related to imports. > > One complains about using * and the other about having duplicate imports. > > I did not actually make these changes, so this makes me wonder if checkstyle > is not typically being run on every project (so maybe I can disable its use > when building the codebase somehow?). > > > On Thu, Jan 9, 2014 at 1:35 PM, Mike Tutkowski > <mike.tutkow...@solidfire.com > > wrote: > > > It looks like we need to apply the checkstyle rules on a > > project-by-project basis. > > > > Are we currently applying these rules to every project or just a subset? > > > > Thanks > > > > > > On Thu, Jan 9, 2014 at 1:04 PM, Mike Tutkowski < > > mike.tutkow...@solidfire.com> wrote: > > > >> I can install the plug-in for Eclipse. > >> > >> Thanks, Alex! > >> > >> > >> On Thu, Jan 9, 2014 at 11:34 AM, Alex Huang > <alex.hu...@citrix.com>wrote: > >> > >>> Mike, > >>> > >>> If you're using eclipse, checkstyle has a plugin that you can install. > >>> Point the plugin to the style file in > >>> tools/checkstyle/cloud-style.xml and it will use the same syntax. > >>> I've always found it much easier to use the plugin than to read the build > outputs. > >>> > >>> If you don't want to install the plugin, I don't think your log copy > >>> didn't include the actual errors. You might want to look further up > >>> or down on your console to see what's the violation. > >>> > >>> --Alex > >>> > >>> > -----Original Message----- > >>> > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] > >>> > Sent: Thursday, January 9, 2014 9:49 AM > >>> > To: dev@cloudstack.apache.org > >>> > Subject: Unfamiliar with checkstyle > >>> > > >>> > Hi, > >>> > > >>> > I was merging some code from 4.3 to master and received three > >>> checkstyle > >>> > errors. > >>> > > >>> > I'm not really familiar with how to find out details of these errors. > >>> Can > >>> > someone point me to the right place to begin my investigation? > >>> > > >>> > All I see right now is the following: > >>> > > >>> > [ERROR] Failed to execute goal > >>> > org.apache.maven.plugins:maven-checkstyle-plugin:2.11:check > >>> > (default) > >>> on > >>> > project cloudstack: Failed during checkstyle execution: There are > >>> > 3 > >>> checkstyle > >>> > errors. -> [Help 1] > >>> > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to > >>> execute > >>> > goal org.apache.maven.plugins:maven-checkstyle-plugin:2.11:check > >>> (default) > >>> > on project cloudstack: Failed during checkstyle execution at > >>> > > >>> > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecuto > >>> r.ja > >>> > va:217) > >>> > at > >>> > > >>> > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecuto > >>> r.ja > >>> > va:153) > >>> > at > >>> > > >>> > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecuto > >>> r.ja > >>> > va:145) > >>> > at > >>> > > >>> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProj > >>> ect(Life > >>> > cycleModuleBuilder.java:84) > >>> > at > >>> > > >>> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProj > >>> ect(Life > >>> > cycleModuleBuilder.java:59) > >>> > at > >>> > > >>> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedB > >>> uild(Lif > >>> > ecycleStarter.java:183) > >>> > at > >>> > > >>> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(Lifecyc > >>> leStarter > >>> > .java:161) > >>> > at > org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) > >>> > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) > >>> > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) > >>> > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) > >>> > at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) > >>> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at > >>> > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorIm > >>> > pl.j > >>> > ava:57) > >>> > at > >>> > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAc > >>> > ces > >>> > sorImpl.java:43) > >>> > at java.lang.reflect.Method.invoke(Method.java:606) > >>> > at > >>> > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(L > >>> > aunch > >>> > er.java:290) > >>> > at > >>> > > >>> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.ja > >>> va:23 > >>> > 0) > >>> > at > >>> > > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode > >>> > (Laun > >>> > cher.java:409) > >>> > at > >>> > > >>> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java > >>> :352) > >>> > Caused by: org.apache.maven.plugin.MojoExecutionException: Failed > >>> during > >>> > checkstyle execution at > >>> > > org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.ex > >>> > ecut > >>> > e(CheckstyleViolationCheckMojo.java:422) > >>> > at > >>> > > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(Defa > >>> > ult > >>> > BuildPluginManager.java:101) > >>> > at > >>> > > >>> > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecuto > >>> r.ja > >>> > va:209) > >>> > ... 19 more > >>> > Caused by: > >>> > org.apache.maven.plugin.checkstyle.CheckstyleExecutorException: > >>> > There are 3 checkstyle errors. > >>> > at > >>> > > org.apache.maven.plugin.checkstyle.DefaultCheckstyleExecutor.execu > >>> > teChe > >>> > ckstyle(DefaultCheckstyleExecutor.java:218) > >>> > at > >>> > > org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.ex > >>> > ecut > >>> > e(CheckstyleViolationCheckMojo.java:413) > >>> > ... 21 more > >>> > > >>> > Thanks! > >>> > > >>> > -- > >>> > *Mike Tutkowski* > >>> > *Senior CloudStack Developer, SolidFire Inc.* > >>> > e: mike.tutkow...@solidfire.com > >>> > o: 303.746.7302 > >>> > Advancing the way the world uses the > >>> > cloud<http://solidfire.com/solution/overview/?video=play> > >>> > *(tm)* > >>> > >> > >> > >> > >> -- > >> *Mike Tutkowski* > >> *Senior CloudStack Developer, SolidFire Inc.* > >> e: mike.tutkow...@solidfire.com > >> o: 303.746.7302 > >> Advancing the way the world uses the > >> cloud<http://solidfire.com/solution/overview/?video=play> > >> *(tm)* > >> > > > > > > > > -- > > *Mike Tutkowski* > > *Senior CloudStack Developer, SolidFire Inc.* > > e: mike.tutkow...@solidfire.com > > o: 303.746.7302 > > Advancing the way the world uses the > > cloud<http://solidfire.com/solution/overview/?video=play> > > *(tm)* > > > > > > -- > *Mike Tutkowski* > *Senior CloudStack Developer, SolidFire Inc.* > e: mike.tutkow...@solidfire.com > o: 303.746.7302 > Advancing the way the world uses the > cloud<http://solidfire.com/solution/overview/?video=play> > *(tm)*
