Re: Review Request 18116: Fix and test GroupBy SQL query creation

2014-02-14 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18116/#review34492 --- Ship it! commit de24d7615099b4a61c65051f505608f9d0ad26db Author: An

Re: Review Request 18116: Fix and test GroupBy SQL query creation

2014-02-14 Thread Ian Southam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18116/ --- (Updated Feb. 14, 2014, 2:10 p.m.) Review request for cloudstack, daan Hoogland

Re: Review Request 18116: Fix and test GroupBy SQL query creation

2014-02-14 Thread Ian Southam
> On Feb. 14, 2014, 1:49 p.m., Hugo Trippaers wrote: > > Ian, > > > > Can you upload a single patch file for this change? The current patch > > consists of several patch files. Patch has been updated sorry about that, seems my diff went wrong! - Ian

Re: Review Request 18116: Fix and test GroupBy SQL query creation

2014-02-14 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18116/#review34487 --- Ian, Can you upload a single patch file for this change? The curren

Re: Review Request 18116: Fix and test GroupBy SQL query creation

2014-02-14 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18116/#review34485 --- Ian, Can you upload a single patch file for this change? The curren

Re: Review Request 18116: Fix and test GroupBy SQL query creation

2014-02-14 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18116/#review34486 --- Ian, Can you upload a single patch file for this change? The curren