----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18116/ -----------------------------------------------------------
(Updated Feb. 14, 2014, 2:10 p.m.) Review request for cloudstack, daan Hoogland and Hugo Trippaers. Changes ------- First patch file contained incorrect patch Repository: cloudstack-git Description ------- Findbugs finding fixed. Incorrect String comparison (==) Uncludes Unit Test (with thanks to Antonio) Diffs (updated) ----- framework/db/src/com/cloud/utils/db/GroupBy.java 716b585 framework/db/src/com/cloud/utils/db/SearchBase.java 3f123be framework/db/test/com/cloud/utils/db/GroupByTest.java PRE-CREATION Diff: https://reviews.apache.org/r/18116/diff/ Testing ------- Thanks, Ian Southam
