Re: Review Request 18016: CLOUDSTACK-5626: Simplifying VM Migrate code

2014-03-09 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18016/#review36628 --- Commit 3b3ae024591fae4db9a6ca991d4838d98b96154e in cloudstack's bran

Re: Review Request 18016: CLOUDSTACK-5626: Simplifying VM Migrate code

2014-03-07 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18016/ --- (Updated March 7, 2014, 3:06 p.m.) Review request for cloudstack, Girish Shilam

Re: Review Request 18016: CLOUDSTACK-5626: Simplifying VM Migrate code

2014-02-20 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18016/#review34996 --- Ship it! Ship It! - Santhosh Edukulla On Feb. 14, 2014, 7:54 a.m

Re: Review Request 18016: CLOUDSTACK-5626: Simplifying VM Migrate code

2014-02-18 Thread Gaurav Aradhye
> On Feb. 12, 2014, 10:09 p.m., Santhosh Edukulla wrote: > > Santhosh, Can you please review this? - Gaurav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18016/#review34291

Re: Review Request 18016: CLOUDSTACK-5626: Simplifying VM Migrate code

2014-02-13 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18016/ --- (Updated Feb. 14, 2014, 1:24 p.m.) Review request for cloudstack, Girish Shilam

Re: Review Request 18016: CLOUDSTACK-5626: Simplifying VM Migrate code

2014-02-12 Thread Santhosh Edukulla
> On Feb. 12, 2014, 4:39 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_cpu_project_limits.py, line 294 > > > > > > Keep the function find_suitable_host, and use it test modules. Use the > > new ap

Re: Review Request 18016: CLOUDSTACK-5626: Simplifying VM Migrate code

2014-02-12 Thread Gaurav Aradhye
> On Feb. 12, 2014, 10:09 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_cpu_limits.py, line 580 > > > > > > Do we need to skip the test or fail it? It's not a failure since the setup is not equipp

Re: Review Request 18016: CLOUDSTACK-5626: Simplifying VM Migrate code

2014-02-12 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18016/#review34291 --- test/integration/component/test_cpu_limits.py