----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18016/#review34291 -----------------------------------------------------------
test/integration/component/test_cpu_limits.py <https://reviews.apache.org/r/18016/#comment64316> Do we need to skip the test or fail it? test/integration/component/test_cpu_project_limits.py <https://reviews.apache.org/r/18016/#comment64317> Keep the function find_suitable_host, and use it test modules. Use the new api mentioned i.e., listForMigration there in that function and abstract that to test cases. This way, test modules dont change often. test/integration/component/test_memory_limits.py <https://reviews.apache.org/r/18016/#comment64318> Why modify all test suites? The better thing may be to use and abstract the listForMigration inside the common library and so with this no tests get changed? - Santhosh Edukulla On Feb. 12, 2014, 4:09 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18016/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 4:09 p.m.) > > > Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-5626 > https://issues.apache.org/jira/browse/CLOUDSTACK-5626 > > > Repository: cloudstack-git > > > Description > ------- > > Removing different ways of obtaining suitable hosts. Used built in API > "findHostsForMigration" and skipped the test if suitable host is not found > instead of throwing assertion error. > Removed unnecessary common function. > > > Diffs > ----- > > test/integration/component/test_cpu_domain_limits.py c427e4f > test/integration/component/test_cpu_limits.py bdf2869 > test/integration/component/test_cpu_project_limits.py a8a1b3c > test/integration/component/test_memory_limits.py 7921e4b > test/integration/component/test_mm_domain_limits.py 68660c1 > test/integration/component/test_mm_project_limits.py c314011 > test/integration/component/test_vpc_vm_life_cycle.py 01373ac > tools/marvin/marvin/integration/lib/common.py e202391 > > Diff: https://reviews.apache.org/r/18016/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Gaurav Aradhye > >
