Re: Review Request 16813: Contrail plugin fixes

2014-01-15 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16813/#review31950 --- Ship it! Applied to MASTER. Thanks. - Sheng Yang On Jan. 15, 20

Re: Review Request 16813: Contrail plugin fixes

2014-01-15 Thread Suresh Balineni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16813/ --- (Updated Jan. 15, 2014, 7:23 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 16813: Contrail plugin fixes

2014-01-14 Thread Sheng Yang
That's not how we deal with patches... Please merge them into one patch and upload to the reviewboard as diff v2 instead. That would be easier for review. Thanks. --Sheng On Tue, Jan 14, 2014 at 5:36 PM, Suresh Balineni < sbalin...@service.juniper.net> wrote: > Hi Sheng, > > This patch cont

Re: Review Request 16813: Contrail plugin fixes

2014-01-14 Thread Suresh Balineni
Hi Sheng, This patch contains two commits.. 1. Previous patch. 2. New updated code with DB transactions removed. If look at the second commit, you will see added diff. Thanks, Suresh Sent from my iPhone On Jan 14, 2014, at 5:32 PM, "Sheng Yang" mailto:sh...@yasker.org>> wrote: This is an aut

Re: Review Request 16813: Contrail plugin fixes

2014-01-14 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16813/#review31839 --- I didn't see the updated patch. Both attached file and diff are old

Re: Review Request 16813: Contrail plugin fixes

2014-01-14 Thread Suresh Balineni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16813/ --- (Updated Jan. 14, 2014, 10:56 p.m.) Review request for cloudstack. Changes --

Re: Review Request 16813: Contrail plugin fixes

2014-01-14 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16813/#review31800 --- Dao.update() doesn't need to be wrapped by transcation. - Sheng Ya

Re: Review Request 16813: Contrail plugin fixes

2014-01-12 Thread Suresh Balineni
Hi Sheng, Please review and ship this master version patch of contrail plugin fixes : https://reviews.apache.org/r/16813/ This patch contains fixes of 4.3 review requests : https://reviews.apache.org/r/16642/ https://reviews.apache.org/r/16805/ Thanks, Suresh From: Suresh Balineni mailto:sbali