Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

On Tue, Apr 16, 2013 at 02:53:43PM +, bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10238/ > --- > > (Upda

Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

> On April 12, 2013, 9:53 a.m., Abhinandan Prateek wrote: > > Ship It! > > Abhinandan Prateek wrote: > The patch does not apply, can you resubmit after checking it. > > bharat kumar wrote: > uploaded the new diff committed - Abhinandan --

Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

> On April 12, 2013, 9:53 a.m., Abhinandan Prateek wrote: > > Ship It! > > Abhinandan Prateek wrote: > The patch does not apply, can you resubmit after checking it. uploaded the new diff - bharat --- This is an automatically genera

Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10238/ --- (Updated April 16, 2013, 2:53 p.m.) Review request for cloudstack and Abhinanda

Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

> On April 12, 2013, 9:53 a.m., Abhinandan Prateek wrote: > > Ship It! The patch does not apply, can you resubmit after checking it. - Abhinandan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10238/#review19060 --- Ship it! Ship It! - Abhinandan Prateek On April 9, 2013, 3 p.m.,

Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

> On April 9, 2013, 6:17 p.m., Likitha Shetty wrote: > > All guest vlan ranges belonging to one physical network are being updated > > in the same column. This would mean there is no way to uniquely identify or > > operate on each of the individual ranges. > > Shouldn't we instead have a separ

Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10238/#review18866 --- All guest vlan ranges belonging to one physical network are being up

Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10238/ --- (Updated April 9, 2013, 3 p.m.) Review request for cloudstack and Abhinandan Pr

Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

> On April 8, 2013, 9:36 p.m., Likitha Shetty wrote: > > server/src/com/cloud/network/NetworkServiceImpl.java, line 2377 > > > > > > Please handle the following 2 corner cases where admin user tries to > > shrink the

RE: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

g; Likitha Shetty; Abhinandan Prateek >Cc: cloudstack; Bharat Kumar >Subject: RE: Review Request: Cloudstack-701 Support for non contiguous vlan >ranges. > >The FS says that the feature only deals with extending the VLAN range when >calling the update physical network API with the new VLA

RE: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

: Abhinandan Prateek Cc: cloudstack; Bharat Kumar; Likitha Shetty Subject: Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges. --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10238/#review18795 --- server/src/com/cloud/network/NetworkServiceImpl.java

Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10238/#review18773 --- server/src/com/cloud/network/NetworkServiceImpl.java

Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10238/#review18684 --- Good test coverage included. Thanks for that. - Chip Childers On

Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10238/ --- (Updated April 4, 2013, 12:36 p.m.) Review request for cloudstack and Abhinanda

Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10238/ --- (Updated April 4, 2013, 12:35 p.m.) Review request for cloudstack and Abhinanda

Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10238/ --- (Updated April 2, 2013, 12:11 p.m.) Review request for cloudstack and Abhinanda