> On April 9, 2013, 6:17 p.m., Likitha Shetty wrote: > > All guest vlan ranges belonging to one physical network are being updated > > in the same column. This would mean there is no way to uniquely identify or > > operate on each of the individual ranges. > > Shouldn't we instead have a separate entry for each range in the > > physical_network table? Or maybe have a new table to hold the guest vlan > > ranges where they are mapped to the corresponding physical network?
we can get the vlanranges by splitting over the semicolon. If you want to do any individual operations on a vlan range you can use the op_dc_vnet_alloc table. I think rather than operating on the vlan range it is better to operate on individual vlan. - bharat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10238/#review18866 ----------------------------------------------------------- On April 9, 2013, 3 p.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10238/ > ----------------------------------------------------------- > > (Updated April 9, 2013, 3 p.m.) > > > Review request for cloudstack and Abhinandan Prateek. > > > Description > ------- > > Cloudstack-701: Support for non contiguous vlan ranges. > > > Diffs > ----- > > api/src/com/cloud/network/NetworkService.java ab6d7bf > api/src/com/cloud/network/PhysicalNetwork.java a2044a6 > api/src/org/apache/cloudstack/api/ApiConstants.java c518830 > > api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java > 06cf38d > server/src/com/cloud/api/ApiResponseHelper.java 64be7f8 > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0 > server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4 > server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4 > server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2 > server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c > server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb > server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a > server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51 > server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec > server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION > server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051 > test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION > > Diff: https://reviews.apache.org/r/10238/diff/ > > > Testing > ------- > > Tested on latest master. > > > Thanks, > > bharat kumar > >
