Re: Question about Global Settings

2014-07-14 Thread Suresh Ramamurthy
Hi Alena, Thanks for pointing out the document about global properties. I have updated NuageVsp plugin to use global properties as mentioned in the document. Thanks Suresh Ramamurthy On Mon, Jul 14, 2014 at 10:54 AM, Alena Prokharchyk < alena.prokharc...@citrix.com> wrote: > Great. Forgot to m

Re: Question about Global Settings

2014-07-14 Thread Alena Prokharchyk
Great. Forgot to mention obvious thing - when follow the implementation from the doc, if the plugin is not loaded during the install/setup, the config will never get inserted to the cloud.configuration table. -Alena. On 7/14/14, 10:45 AM, "Mike Tutkowski" wrote: >Thanks, Alena! This is exactly

Re: Question about Global Settings

2014-07-14 Thread Mike Tutkowski
Thanks, Alena! This is exactly what I was wondering about. I can put this in my code review. On Mon, Jul 14, 2014 at 10:42 AM, Alena Prokharchyk < alena.prokharc...@citrix.com> wrote: > Mike, may be you already know this info, putting it here in case someone > is not aware of that. When global

Re: Question about Global Settings

2014-07-14 Thread Alena Prokharchyk
Mike, may be you already know this info, putting it here in case someone is not aware of that. When global config variables are plugin specific, they have to inserted by the manager from your plugin; they should never be put to Config.java class. To implement it, make your manager implement Config

Re: Question about Global Settings

2014-07-14 Thread Erik Weber
We have midonet-specific settings in there, wouldn't that be vendor specific? I'm totally unfamiliar with midonet, so I have to ask. Erik 13. juli 2014 07:01 skrev "Mike Tutkowski" følgende: > Hi, > > I'm doing a code review and had a question that I thought someone might be > able to answer for

Re: Question about Global Settings

2014-07-14 Thread Daan Hoogland
If we do that we must provide uninstall/downgrade mechs as well. On Mon, Jul 14, 2014 at 7:02 AM, Amit Das wrote: >> Ideally you would want to create db schema/configurations related to a >> plugin only if it is installed/used. > > > Agree completely. A plugin specific settings should be trigger

Re: Question about Global Settings

2014-07-13 Thread Amit Das
> Ideally you would want to create db schema/configurations related to a > plugin only if it is installed/used. Agree completely. A plugin specific settings should be triggered from plugin code the moment the specific plugin is loaded. Regards, Amit *CloudByte Inc.*

Re: Question about Global Settings

2014-07-13 Thread Koushik Das
I don't see any issues using vendor/plugin specific settings as long as its use is limited to the plugin code. But there is limitations in the framework related to the way plugin specific stuff is handled. Ideally you would want to create db schema/configurations related to a plugin only if it