Great. Forgot to mention obvious thing - when follow the implementation from the doc, if the plugin is not loaded during the install/setup, the config will never get inserted to the cloud.configuration table.
-Alena. On 7/14/14, 10:45 AM, "Mike Tutkowski" <mike.tutkow...@solidfire.com> wrote: >Thanks, Alena! This is exactly what I was wondering about. > >I can put this in my code review. > > >On Mon, Jul 14, 2014 at 10:42 AM, Alena Prokharchyk < >alena.prokharc...@citrix.com> wrote: > >> Mike, may be you already know this info, putting it here in case someone >> is not aware of that. When global config variables are plugin specific, >> they have to inserted by the manager from your plugin; they should never >> be put to Config.java class. >> >> To implement it, make your manager implement Configurable.java. Here is >> the FS explaining it in more details: >> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Configuration >> >> -Alena. >> >> On 7/14/14, 1:47 AM, "Daan Hoogland" <daan.hoogl...@gmail.com> wrote: >> >> >If we do that we must provide uninstall/downgrade mechs as well. >> > >> >On Mon, Jul 14, 2014 at 7:02 AM, Amit Das <amit....@cloudbyte.com> >>wrote: >> >>> Ideally you would want to create db schema/configurations related >>to a >> >>> plugin only if it is installed/used. >> >> >> >> >> >> Agree completely. A plugin specific settings should be triggered from >> >> plugin code the moment the specific plugin is loaded. >> >> >> >> >> >> Regards, >> >> Amit >> >> *CloudByte Inc.* <http://www.cloudbyte.com/> >> >> >> >> >> >> On Mon, Jul 14, 2014 at 9:46 AM, Koushik Das <koushik....@citrix.com> >> >>wrote: >> >> >> >>> I don't see any issues using vendor/plugin specific settings as >>long as >> >>> its use is limited to the plugin code. >> >>> >> >>> But there is limitations in the framework related to the way plugin >> >>> specific stuff is handled. Ideally you would want to create db >> >>> schema/configurations related to a plugin only if it is >> >>>installed/used. But >> >>> currently thats not the case, all plugin schemas are always created. >> >>> >> >>> >> >>> On 13-Jul-2014, at 10:31 AM, Mike Tutkowski >> >>><mike.tutkow...@solidfire.com> >> >>> wrote: >> >>> >> >>> > Hi, >> >>> > >> >>> > I'm doing a code review and had a question that I thought someone >> >>>might >> >>> be >> >>> > able to answer for me: >> >>> > >> >>> > Do we typically allow vendor-specific config values in Global >> >>>Settings? >> >>> > >> >>> > Thanks! >> >>> > >> >>> > -- >> >>> > *Mike Tutkowski* >> >>> > *Senior CloudStack Developer, SolidFire Inc.* >> >>> > e: mike.tutkow...@solidfire.com >> >>> > o: 303.746.7302 >> >>> > Advancing the way the world uses the cloud >> >>> > <http://solidfire.com/solution/overview/?video=play>* * >> >>> >> >>> >> > >> > >> > >> >-- >> >Daan >> >> > > >-- >*Mike Tutkowski* >*Senior CloudStack Developer, SolidFire Inc.* >e: mike.tutkow...@solidfire.com >o: 303.746.7302 >Advancing the way the world uses the cloud ><http://solidfire.com/solution/overview/?video=play>**
