RE: Coding Standards Questions

2014-04-14 Thread Ian Southam
ati-Nagy [mailto:gabor.apati-n...@citrix.com] Sent: maandag 14 april 2014 12:59 To: dev@cloudstack.apache.org Subject: RE: Coding Standards Questions To my mind having multiple return statements might be unclear sometimes, but personally I do prefer this option. In this case we can easily make s

RE: Coding Standards Questions

2014-04-14 Thread Gabor Apati-Nagy
t: 14 April 2014 10:35 To: dev@cloudstack.apache.org Subject: RE: Coding Standards Questions I agree that pulling the return value out into a variable and returning it at the end can be clearer, but I wouldn't want to make an absolute rule about it. Sometimes returning early can reduce the

Re: Coding Standards Questions

2014-04-14 Thread Rajani Karuturi
> -- > Stephen Turner > > > -Original Message- > From: Alex Hitchins [mailto:a...@alexhitchins.com] > Sent: 11 April 2014 21:45 > To: dev@cloudstack.apache.org > Subject: RE: Coding Standards Questions > > Daan, > > Are you referring to keeping l

RE: Coding Standards Questions

2014-04-14 Thread Stephen Turner
lto:a...@alexhitchins.com] Sent: 11 April 2014 21:45 To: dev@cloudstack.apache.org Subject: RE: Coding Standards Questions Daan, Are you referring to keeping line lengths up to 80 characters? Sorry - tired eyes. My thoughts were more that in a function there should only be one "return&

Re: Coding Standards Questions

2014-04-13 Thread Koushik Das
all nested in layers of if/else statements. +1. > > > Alex Hitchins | 07788 423 969 | 01892 523 587 > - > > -Original Message- > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > Sent: 11 April 2014 18:30 > To:

Re: Coding Standards Questions

2014-04-11 Thread Daan Hoogland
--- > > -Original Message- > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > Sent: 11 April 2014 18:30 > To: dev > Subject: Re: Coding Standards Questions > > H Alex, > > I agree with you that would be nicer if your function fits in a screen.

RE: Coding Standards Questions

2014-04-11 Thread Alex Hitchins
92 523 587 - -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: 11 April 2014 18:30 To: dev Subject: Re: Coding Standards Questions H Alex, I agree with you that would be nicer if your function fits in a screen. Another coding con

Re: Coding Standards Questions

2014-04-11 Thread Daan Hoogland
H Alex, I agree with you that would be nicer if your function fits in a screen. Another coding convention we should adhere to. As it is I think it not so much 'not a major concern' as too much to ask for. Feel free to refactor and submit patches;) Daan On Fri, Apr 11, 2014 at 9:54 AM, Alex Hitch