On Mon, Feb 3, 2014 at 7:55 AM, Rajani Karuturi
wrote:
> you please do it on 4.3-forward and master as well.
I'll do it on 4.3-forward and I'll be on all findbugs issues on master
so it'll pass by automatically
Hi Daan/Ian,
looks like the change is only in 4.3. Can you please do it on 4.3-forward and
master as well.
Thanks,
~Rajani
On 03-Feb-2014, at 12:21 am, Daan Hoogland wrote:
> just pushed :(
>
>
> On Sun, Feb 2, 2014 at 7:50 PM, Ian Duffy wrote:
>> Daan,
>>
>> Have this done already, jus
just pushed :(
On Sun, Feb 2, 2014 at 7:50 PM, Ian Duffy wrote:
> Daan,
>
> Have this done already, just about to push.
>
>
> On 2 February 2014 18:47, Daan Hoogland wrote:
>
>> never mind, I thought you are committer. I'll fix
>>
>> On Sun, Feb 2, 2014 at 6:52 PM, Rajani Karuturi
>> wrote:
>>
Daan,
Have this done already, just about to push.
On 2 February 2014 18:47, Daan Hoogland wrote:
> never mind, I thought you are committer. I'll fix
>
> On Sun, Feb 2, 2014 at 6:52 PM, Rajani Karuturi
> wrote:
> > Sure Daan. Will submit a review request for master and 4.3-forward
> tomorrow m
never mind, I thought you are committer. I'll fix
On Sun, Feb 2, 2014 at 6:52 PM, Rajani Karuturi
wrote:
> Sure Daan. Will submit a review request for master and 4.3-forward tomorrow
> morning IST.
>
> Thanks,
> ~Rajani
>
>
>
> On 02-Feb-2014, at 8:17 pm, Daan Hoogland wrote:
>
>> On Sun, Feb 2
Sure Daan. Will submit a review request for master and 4.3-forward tomorrow
morning IST.
Thanks,
~Rajani
On 02-Feb-2014, at 8:17 pm, Daan Hoogland wrote:
> On Sun, Feb 2, 2014 at 12:48 PM, Rajani Karuturi
> wrote:
>> what we should use is new String(bytes[])
>
>
> ok, makes sense. Can you
On Sun, Feb 2, 2014 at 12:48 PM, Rajani Karuturi
wrote:
> what we should use is new String(bytes[])
ok, makes sense. Can you revert my commit and make a new patch?
thanks,
Daan
sun.jndi.ldap.read.timeout", "500");-
environment.put("com.sun.jndi.ldap.connect.pool", "true");
Is that reported by find bug? I don't know this code so not sure
if it is
intentional or not ?
The point is there may be unintended risks in allowing late
chan
imesh,
>>>>>>>>>
>>>>>>>>> Tested all those changes to detail. Those lines were removed due to
>>>>>>>>> unexpected behavior that I had not spotted until now.
>>>>>>>>>
>>>>>>>>&
forward,
> >>>>>>> Thanks
> >>>>>>>
> >>>>>>> Ian.
> >>>>>>> On 29 Jan 2014 00:07, "Animesh Chaturvedi" <
> >> animesh.chaturv...@citrix.com>
> >>>>>>> wrote:
> >
t;>>>>> for a limited time.
>>>>>>>
>>>>>>> Please pull the changes forward,
>>>>>>> Thanks
>>>>>>>
>>>>>>> Ian.
>>>>>>> On 29 Jan 2014 00:07, "Animesh Chaturvedi" <
t;>>>> wrote:
> >>>>>
> >>>>>> If I look at this commit for example
> >>>>>>
> >>>>>>
> >>>>>>
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit
t;>>> environment.put("com.sun.jndi.ldap.connect.pool", "true");
>>>>>>
>>>>>> Is that reported by find bug? I don't know this code so not sure if it
>>>>>> is
>>>>>> int
t;
>>>>> It removes the two lines from LdapContextFactory.java
>>>>>
>>>>> environment.put("com.sun.jndi.ldap.read.timeout", "500");-
>>>>> environment.put("com.sun.jndi.ldap.connect.pool", "true")
ut("com.sun.jndi.ldap.connect.pool", "true");
>>>>
>>>> Is that reported by find bug? I don't know this code so not sure if it is
>>>> intentional or not ?
>>>>
>>>> The point is there may be unintended risks in allowi
by find bug? I don’t know this code so not sure if it is
>>> intentional or not ?
>>>
>>> The point is there may be unintended risks in allowing late changes.
>>>
>>>
>>>
>>> -Original Message-
>>> From: Ani
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Wednesday, January 29, 2014 1:06 PM
To: dev; Animesh Chaturvedi
Subject: Re: Findbugs report on 4.3-forward
H Animesh,
I am done cherry-picking, compiling and pushing.
[Animesh] Cool, I will also need to
H Animesh,
I am done cherry-picking, compiling and pushing.
I wonder if now is opportune to build a new rc. shouldn't we wait till
more people have tested? I for instance (doing a quarter of the test
plans that we have at Schuberg Philis) ran into some issues and am not
sure yet if they are in th
On Wed, Jan 29, 2014 at 9:50 PM, Daan Hoogland wrote:
> and will the push
and will then push
On Wed, Jan 29, 2014 at 9:36 PM, Animesh Chaturvedi
wrote:
> [Animesh] I know but at this time we need closer scrutiny and just the
> specific change helps in that. There was a similar comment in private when
> some of us were reviewing security patches.
point taken
I am not cherry picking the
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Wednesday, January 29, 2014 12:14 PM
To: dev
Subject: Re: Findbugs report on 4.3-forward
On Wed, Jan 29, 2014 at 8:48 PM, Animesh Chaturvedi
wrote:
> Instant gratification on fixing something is trump
nesday, January 29, 2014 8:47 AM
> To: dev
> Subject: Re: Findbugs report on 4.3-forward
>
> The first five I allready posted. The ones between brackets seem minor to me.
> Then again they also pose the least risk so in my opinion you should pull
> them all. The last one is a bug
On Wed, Jan 29, 2014 at 8:48 PM, Animesh Chaturvedi
wrote:
> Instant gratification on fixing something is trumping managing risk.
I don't think I like the implication of that remark. I am sure you
mean well and are tired.
> The patches are littered with formatting changes that make review
> time
good point Mike,
I would like to add that in our case 'quality' means 'usability'. We
are not writing military or madical grade code. However I don't want
to tell a big far eastern telco that their it is out because i left an
== in the code that was meant to be an equals() call, or a leak
because
build another RC today.
Animesh
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Wednesday, January 29, 2014 8:47 AM
To: dev
Subject: Re: Findbugs report on 4.3-forward
The first five I allready posted. The ones between brackets seem minor to me.
Then again
-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
Sent: Wednesday, January 29, 2014 11:15 AM
To: dev@cloudstack.apache.org
Subject: Re: Findbugs report on 4.3-forward
I agree that quality should be our primary focus.
[Animesh] No one would disagree that
I agree that quality should be our primary focus. My one point of caution
here would be, "How risky are these fixes?"
Just because we believe we have fixes for issues does not necessarily mean
they should be put in a release late in the game. We have to weigh the
benefits of having the fixes versu
On Tue, Jan 28, 2014 at 11:36:52PM +0100, Hugo Trippaers wrote:
> Hey Animesh,
>
> Not in agreement here. These are squashed bugs and we want as less bugs in
> the release as possible.
>
> This is why we test any RC before we release it. I say include all the big
> fixes we have in the release.
please pull d38a50343130f6f147e2c9c7b2e32a43f31c7e6b to 4.3
this one came out of our regression testing, I hope other people are
keeping up the testing as well in spite of all the discussion on the
RC!!!
thanks for your patience Animesh,
Daan
On Wed, Jan 29, 2014 at 5:55 PM, Daan Hoogland wrote
On Wed, Jan 29, 2014 at 5:47 PM, Daan Hoogland wrote:
> and
>
> caf17c2f46bf317ec8966b08aaff728a73fda14a
never mind that last one, i was in a hury and screwed up. will revert
d local vars. This doesn't seem vital
>>> (or dangerous) but pulling only one seems very few.
>>>
>>>
>>> On Wed, Jan 29, 2014 at 7:11 AM, Animesh Chaturvedi
>>> wrote:
>>>>
>>>>
>>>> -Original Message-
>>
gt;>>
>>> -Original Message-
>>> From: Ian Duffy [mailto:i...@ianduffy.ie]
>>> Sent: Tuesday, January 28, 2014 6:34 PM
>>> To: CloudStack Dev
>>> Subject: RE: Findbugs report on 4.3-forward
>>>
>>> Hi Animesh,
>>>
, Animesh Chaturvedi
> wrote:
>>
>>
>> -Original Message-
>> From: Ian Duffy [mailto:i...@ianduffy.ie]
>> Sent: Tuesday, January 28, 2014 6:34 PM
>> To: CloudStack Dev
>> Subject: RE: Findbugs report on 4.3-forward
>>
>> Hi Animesh,
>>
-
> From: Ian Duffy [mailto:i...@ianduffy.ie]
> Sent: Tuesday, January 28, 2014 6:34 PM
> To: CloudStack Dev
> Subject: RE: Findbugs report on 4.3-forward
>
> Hi Animesh,
>
> Tested all those changes to detail. Those lines were removed due to
> unexpected behavior that I had not
-Original Message-
From: Ian Duffy [mailto:i...@ianduffy.ie]
Sent: Tuesday, January 28, 2014 6:34 PM
To: CloudStack Dev
Subject: RE: Findbugs report on 4.3-forward
Hi Animesh,
Tested all those changes to detail. Those lines were removed due to unexpected
behavior that I had not
A quick look at 20+ commits from
>> Daan show many formatting changes that may not be necessary and hinder
>> quick review.
>>
>> -Original Message-
>> From: Hugo Trippaers [mailto:trip...@gmail.com]
>> Sent: Tuesday, January 28, 2014 3:16 PM
>>
ick review.
>
> -Original Message-
> From: Hugo Trippaers [mailto:trip...@gmail.com]
> Sent: Tuesday, January 28, 2014 3:16 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Findbugs report on 4.3-forward
>
>
>
> Sent from my iPhone
>
> > On 28 jan.
imesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
Sent: Tuesday, January 28, 2014 3:35 PM
To: dev@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Are you sure all of the ones are needed. A quick look at 20+ commits from Daan
show many formatting changes that may not be necessary
@cloudstack.apache.org
Subject: Re: Findbugs report on 4.3-forward
Sent from my iPhone
> On 28 jan. 2014, at 23:50, Animesh Chaturvedi
> wrote:
>
>
> -Original Message-
> From: Hugo Trippaers [mailto:trip...@gmail.com]
> Sent: Tuesday, January 28, 2014 2:37 PM
> To: dev@cl
c5a1910b6370585a1d61638b8310c3ecba5ef
>>>>>
>>>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h
>>>>> = 60ac12780bfa1604902a89d5dc7937a8b9334e0d
>>>>> I think you want the last one which has fixes for NetUtils and
>&
-Original Message-
From: Hugo Trippaers [mailto:trip...@gmail.com]
Sent: Tuesday, January 28, 2014 2:37 PM
To: dev@cloudstack.apache.org
Cc: dev@cloudstack.apache.org
Subject: Re: Findbugs report on 4.3-forward
Hey Animesh,
Not in agreement here. These are squashed bugs and we want as
h he called -1.
>
> Thanks
> Animesh
>
> -Original Message-
> From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
> Sent: Tuesday, January 28, 2014 1:29 AM
> To: dev
> Subject: Re: Findbugs report on 4.3-forward
>
> Hey Animesh,
>
> I
Of Hugo Trippaers
> Sent: Tuesday, January 28, 2014 1:29 AM
> To: dev
> Subject: Re: Findbugs report on 4.3-forward
>
> Hey Animesh,
>
> I agree with Daan here. We focussed on the bugs with a findbugs annotation of
> scariest. I think that would warrant them to be includ
Hugo's commit for which he called -1.
Thanks
Animesh
-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Tuesday, January 28, 2014 1:29 AM
To: dev
Subject: Re: Findbugs report on 4.3-forward
Hey Animesh,
I agree with Daan here. We focussed o
you make limited changes directly to
4.3? I
want to build another RC later tonight
Animesh
-Original Message-
From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
Sent: Monday, January 27, 2014 1:30 PM
To: dev@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Ag
ncludes more files. Can you make limited changes directly to 4.3? I
>>> want to build another RC later tonight
>>>
>>> Animesh
>>>
>>>
>>> -Original Message-
>>> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
>>>
gt; >> want to build another RC later tonight
> >>
> >> Animesh
> >>
> >>
> >> -Original Message-
> >> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> >> Sent: Monday, January 27, 2014 1:30 PM
> >&g
>>
>> -Original Message-
>> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
>> Sent: Monday, January 27, 2014 1:30 PM
>> To: dev@cloudstack.apache.org
>> Subject: RE: Findbugs report on 4.3-forward
>>
>> Agreed
>>
>>
imesh
>>
>>
>> -Original Message-
>> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
>> Sent: Monday, January 27, 2014 1:30 PM
>> To: dev@cloudstack.apache.org
>> Subject: RE: Findbugs report on 4.3-forward
>>
>> Agreed
&
ginal Message-
> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> Sent: Monday, January 27, 2014 1:30 PM
> To: dev@cloudstack.apache.org
> Subject: RE: Findbugs report on 4.3-forward
>
> Agreed
>
> We need to fix the most important ones for 4.3. There may be assump
: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
Sent: Monday, January 27, 2014 1:30 PM
To: dev@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Agreed
We need to fix the most important ones for 4.3. There may be assumptions in the
code which we may not know and may get
[mailto:da...@gnsa.us]
Sent: Monday, January 27, 2014 11:46 AM
To: dev@cloudstack.apache.org
Subject: Re: Findbugs report on 4.3-forward
So just curious if I am the only one concerned about a ton of fixes going in at
the last minute. If the fixes are for serious bugs and we have consensus around
On Mon, Jan 27, 2014 at 2:58 PM, Hugo Trippaers wrote:
> Hey David,
>
> As always you are completely right.
I plan on referring to this message alot in the future. Especially in
discussions with my wife. :)
> I feel a bit bad about getting the findbugs report through at the last
> moment. Howe
;
>> On Mon, Jan 27, 2014 at 3:48 AM, Animesh Chaturvedi
>> wrote:
>>> Good job fellas. I see a number of commits 20+ into 4.3-forward branch. Are
>>> their specific commits you want me to pick up out of these?
>>>
>>> Animesh
>>>
>>&
e-
>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> Sent: Sunday, January 26, 2014 2:41 AM
>> To: dev
>> Subject: Re: Findbugs report on 4.3-forward
>>
>> I didn't get very far last night and will be looking at the server package
>> again
their specific commits you want me to pick up out of these?
>
> Animesh
>
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Sunday, January 26, 2014 2:41 AM
> To: dev
> Subject: Re: Findbugs report on 4.3-forward
>
> I didn't ge
report on 4.3-forward
I didn't get very far last night and will be looking at the server package
again this afternoon.
bon appétit,
On Sun, Jan 26, 2014 at 1:36 AM, Ian Duffy wrote:
> Hi,
>
> Fixed the issues highlighted in the ldap user authentication package.
>
> Have p
I didn't get very far last night and will be looking at the server
package again this afternoon.
bon appétit,
On Sun, Jan 26, 2014 at 1:36 AM, Ian Duffy wrote:
> Hi,
>
> Fixed the issues highlighted in the ldap user authentication package.
>
> Have pushed to 4.3-forward.
>
> Thanks,
> Ian
>
>
>
Hi,
Fixed the issues highlighted in the ldap user authentication package.
Have pushed to 4.3-forward.
Thanks,
Ian
On 25 January 2014 22:26, Daan Hoogland wrote:
> > or reply to this mail with the filename you are working on
> I'll be looking at the server package as it seems to contain the m
> or reply to this mail with the filename you are working on
I'll be looking at the server package as it seems to contain the most issues.
On Sat, Jan 25, 2014 at 4:00 PM, Hugo Trippaers wrote:
> I’ve also added a job to master with the Findbugs report and the cobertura
> code coverage report.
>
I’ve also added a job to master with the Findbugs report and the cobertura code
coverage report.
Good stuff, we have a 12% coverage of our classes with unit tests. Huge
improvement over the last release where we had 4% iirc. We have 306 reports
from Findbugs, of which the majority are internati
Thanks!
Random access. :-) Either push any fixes to the 4.3-forward branch for Animesh
to look at, or reply to this mail with the filename you are working on. I won’t
working on anything tonight, so feel free to go ahead without the sync.
Cheers,
Hugo
On 25 jan. 2014, at 14:13, Daan Hooglan
H Hugo,
I'll spend some time on it tonight. Do you have a work load
distribution scheme or is it random access?
;)
regards
On Sat, Jan 25, 2014 at 12:39 PM, Hugo Trippaers wrote:
> Hey all,
>
> I've made Jenkins run the findbugs analysis on 4.3-forward. Is there somebody
> who is willing to he
63 matches
Mail list logo
