Re: DatabaseUpgradeChecker and running from eclipse

2013-09-19 Thread Daan Hoogland
On Thu, Sep 19, 2013 at 6:12 PM, Darren Shepherd wrote: > Only to test builds before commit. mvn is too slow. That's probably it. I run from eclipse but usually do a build first. That is going to change one minute ago, thanks. i'll keep an eye on the dbupgradechecker

RE: DatabaseUpgradeChecker and running from eclipse

2013-09-19 Thread Alex Huang
Thursday, September 19, 2013 10:11 AM > To: dev@cloudstack.apache.org > Subject: Re: DatabaseUpgradeChecker and running from eclipse > > So I just looked at DatabaseCreator and noticed it calls > PremiumDatabaseUpgradeChecker, but on startup we call > DatabaseUpgradeChecker. W

RE: DatabaseUpgradeChecker and running from eclipse

2013-09-19 Thread Alex Huang
Ah...got it. Makes sense. --Alex > -Original Message- > From: Darren Shepherd [mailto:darren.s.sheph...@gmail.com] > Sent: Thursday, September 19, 2013 10:38 AM > To: dev@cloudstack.apache.org > Subject: Re: DatabaseUpgradeChecker and running from eclipse > >

Re: DatabaseUpgradeChecker and running from eclipse

2013-09-19 Thread Darren Shepherd
ent: Thursday, September 19, 2013 10:11 AM > > To: dev@cloudstack.apache.org > > Subject: Re: DatabaseUpgradeChecker and running from eclipse > > > > So I just looked at DatabaseCreator and noticed it calls > > PremiumDatabaseUpgradeChecker, but on startup we call &g

Re: DatabaseUpgradeChecker and running from eclipse

2013-09-19 Thread Darren Shepherd
code. That was supposed to happen in > 4.2 but never happened. It might be a good time to add that in now. > > --Alex > > > -Original Message- > > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > > Sent: Thursday, September 19, 2013 9:35 AM > > To: dev

RE: DatabaseUpgradeChecker and running from eclipse

2013-09-19 Thread Alex Huang
gt; Subject: Re: DatabaseUpgradeChecker and running from eclipse > > On Thu, Sep 19, 2013 at 6:12 PM, Darren Shepherd > wrote: > > Only to test builds before commit. mvn is too slow. > > That's probably it. I run from eclipse but usually do a build first. > That is going to change one

Re: DatabaseUpgradeChecker and running from eclipse

2013-09-19 Thread Darren Shepherd
I just created https://reviews.apache.org/r/14231/ to remove the version check that finds the JDK version. I can't see why we would ever want to find the JDK version, so might as well just not check and fall through to the existing logic that does "if (currentVersion==null) return" Darren On Th

Re: DatabaseUpgradeChecker and running from eclipse

2013-09-19 Thread Darren Shepherd
Its has to do with my maven setup in Eclipse really. So import all the projects then create a new Maven Build Debug Configuration with Base Directory: ${workspace_loc:/cloudstack} Goals: -pl :cloud-client-ui jetty:run Check "Resolve Workspace Artifacts" So the issue comes from "Resolve Workspace

Re: DatabaseUpgradeChecker and running from eclipse

2013-09-19 Thread Daan Hoogland
Darren, what is your scenario to run into this? I had some upgrade paths to run through but didn't encounter this. regards, Daan On Wed, Sep 11, 2013 at 6:58 PM, Darren Shepherd wrote: > So I run ACS from eclipse for development, but DatabaseUpgradeChecker does > the following > > String current