Its getting the JDK version because of this.getClass().getSuperclass().getPackage().getImplementationVersion(); which it only check if this.getClass().getPackage().getImplementationVersion() is null. So parent is java.lang.Object, so it gets the JDK version. I understand your really looking for 4.3.0-SNAPSHOT that is put in the MANIFEST.MF in the mvn build. The patch I put on review board is to remove the getSuperclass() check as that seems to be never a good idea.
Darren On Thu, Sep 19, 2013 at 10:27 AM, Alex Huang <alex.hu...@citrix.com> wrote: > Before cloudstack was donated to apache, it had an open source version and > a non-open source portion (which included vmware, f5, and juniper). Now, > everything is open source but that division is sometimes still in the > files. You can basically merge those files now. > > As for jdk version, that's not what's recording. The version that's > supposed to be recorded is CloudStack's version. Not sure why through > eclipse, you're getting the jdk version. > > --Alex > > > -----Original Message----- > > From: Darren Shepherd [mailto:darren.s.sheph...@gmail.com] > > Sent: Thursday, September 19, 2013 10:11 AM > > To: dev@cloudstack.apache.org > > Subject: Re: DatabaseUpgradeChecker and running from eclipse > > > > So I just looked at DatabaseCreator and noticed it calls > > PremiumDatabaseUpgradeChecker, but on startup we call > > DatabaseUpgradeChecker. What is this madness? Why are there two db > > upgrade classes? > > > > Darren > > > > > > On Thu, Sep 19, 2013 at 10:04 AM, Alex Huang <alex.hu...@citrix.com> > > wrote: > > > > > Around 4.1 timeframe, Rohit added DatabaseCreator to call > > > DatabaseUpgradeChecker to create and upgrade the database but forgot > > > to remove it from the server configuration. We should simply add a > > > DatabaseVesionChecker for the server configuration to check if the > > > database is at the version expected for the code. That was supposed > > > to happen in > > > 4.2 but never happened. It might be a good time to add that in now. > > > > > > --Alex > > > > > > > -----Original Message----- > > > > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > > > > Sent: Thursday, September 19, 2013 9:35 AM > > > > To: dev > > > > Subject: Re: DatabaseUpgradeChecker and running from eclipse > > > > > > > > On Thu, Sep 19, 2013 at 6:12 PM, Darren Shepherd > > > > <darren.s.sheph...@gmail.com> wrote: > > > > > Only to test builds before commit. mvn is too slow. > > > > > > > > That's probably it. I run from eclipse but usually do a build first. > > > > That is going to change one minute ago, thanks. i'll keep an eye on > > > > the dbupgradechecker > > > >
