On Wed, May 08, 2013 at 06:10:11AM +, Likitha Shetty wrote:
> Prasanna, fixed the error.
>
> About the API naming of commands related to guest vlan range dedication, the
> API names were chosen to be consistent with the commands related to
> dedication of other resources (Host, Pod, Cluster
g]
>Sent: Tuesday, May 07, 2013 3:37 PM
>To: dev@cloudstack.apache.org
>Subject: Re: [MERGE] Dedicate guest vlan ranges to account
>
>On Mon, May 06, 2013 at 08:52:38AM +, Likitha Shetty wrote:
>> Thanks for reviewing.
>> Merged in to master - c8d843241e144288300c191
On Mon, May 06, 2013 at 08:52:38AM +, Likitha Shetty wrote:
> Thanks for reviewing.
> Merged in to master - c8d843241e144288300c1912a25b201e010bb7a0.
>
I tried to run your test but looks like the AccessChecks weren't in
place for your APIs. Since these are admin (?) APIs I've put them into
co
gt; From: Likitha Shetty [mailto:likitha.she...@citrix.com]
>> > Sent: Thursday, May 02, 2013 12:28 PM
>> > To: dev@cloudstack.apache.org
>> > Subject: RE: [MERGE] Dedicate guest vlan ranges to account
>> >
>> > Updated branch dedicate-guest
hursday, May 02, 2013 12:28 PM
> > To: dev@cloudstack.apache.org
> > Subject: RE: [MERGE] Dedicate guest vlan ranges to account
> >
> > Updated branch dedicate-guest-vlan-ranges_2 with the suggested changes.
> >
> > Thanks,
> > Likitha
> >
> > &g
Looks good to me
+1 to merge
Cheers,
Hugo
> -Original Message-
> From: Likitha Shetty [mailto:likitha.she...@citrix.com]
> Sent: Thursday, May 02, 2013 12:28 PM
> To: dev@cloudstack.apache.org
> Subject: RE: [MERGE] Dedicate guest vlan ranges to account
>
> Up
Updated branch dedicate-guest-vlan-ranges_2 with the suggested changes.
Thanks,
Likitha
>-Original Message-
>From: Likitha Shetty [mailto:likitha.she...@citrix.com]
>Sent: Thursday, May 02, 2013 10:58 AM
>To: dev@cloudstack.apache.org
>Subject: RE: [MERGE] Dedicate guest
Thanks for taking a look Hugo.
I will update the branch with the fixes.
Thanks,
Likitha
>-Original Message-
>From: Hugo Trippaers [mailto:htrippa...@schubergphilis.com]
>Sent: Wednesday, May 01, 2013 5:07 PM
>To: dev@cloudstack.apache.org
>Subject: RE: [MERGE] Dedicate gu
Likitha,
Couple of remarks on the merge request:
I think the calls you added to the system should fail with an informative error
message if the physical network does not have the isolation type VLAN, as your
code is only usable in networks with VLAN style isolation.
Can you double check your f
