Prasanna, fixed the error. About the API naming of commands related to guest vlan range dedication, the API names were chosen to be consistent with the commands related to dedication of other resources (Host, Pod, Cluster and Zone - https://reviews.apache.org/r/10797/ ). In fact I was thinking of renaming the commands related to Public Ip Ranges dedication to : dedicatePublicIpRange releaseDedicatedPublicIpRange
Since we are operating on a dedicated resource isn't it more fitting? Thank you, Likitha -----Original Message----- >From: Prasanna Santhanam [mailto:t...@apache.org] >Sent: Tuesday, May 07, 2013 3:37 PM >To: dev@cloudstack.apache.org >Subject: Re: [MERGE] Dedicate guest vlan ranges to account > >On Mon, May 06, 2013 at 08:52:38AM +0000, Likitha Shetty wrote: >> Thanks for reviewing. >> Merged in to master - c8d843241e144288300c1912a25b201e010bb7a0. >> > >I tried to run your test but looks like the AccessChecks weren't in place for >your >APIs. Since these are admin (?) APIs I've put them into commands.properties.in >with the admin mask. The APIs then are discovered successfully by the server. >But the test fails as shown >below: > >~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests -- >with-marvin --marvin-config=setup/dev/advanced.cfg >test/integration/smoke/test_guest_vlan_range.py --load Test guest vlan range >dedication ... ERROR > >================================================================= >===== >ERROR: Test guest vlan range dedication >---------------------------------------------------------------------- >Traceback (most recent call last): > File "/Users/tsp/workspace/cloudstack/incubator- >cloudstack/test/integration/smoke/test_guest_vlan_range.py", line 155, in >test_dedicateGuestVlanRange > id=dedicate_guest_vlan_range_response.id > File "/Library/Python/2.7/site-packages/marvin/integration/lib/base.py", line >2205, in listDedicated > return map(lambda pn : PhysicalNetwork(pn.__dict__), >apiclient.listDedicatedGuestVlanRanges(cmd)) > File "/Library/Python/2.7/site- >packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 819, in >listDedicatedGuestVlanRanges > response = self.connection.marvin_request(command, >response_type=response, method=method) > File "/Library/Python/2.7/site-packages/marvin/cloudstackConnection.py", line >215, in marvin_request > response = jsonHelper.getResultObj(response.json(), response_type) > File "/Library/Python/2.7/site-packages/marvin/jsonHelper.py", line 128, in >getResultObj > raise >cloudstackException.cloudstackAPIException(responseName.replace("response", >""), errMsg) >cloudstackAPIException: Execute cmd: listdedicatedguestvlanranges failed, due >to: errorCode: 431, errorText:Unable to execute API command >listdedicatedguestvlanranges due to invalid value. Invalid parameter id >value=c6fe7bf1-adb1-4423-8ac9-6ea6febea147 due to incorrect long value >format, or entity does not exist or due to incorrect parameter annotation for >the >field in api cmd class. > >This looks like an annotation/type error in the field for id. Can you please >take a >look? > > >Also, I'm not sure if the naming can be made less verbose for the dedicateXxx >APIs. > >For public IP dedication we simply call: >dedicatePublicIpRange >releasePublicIpRange >listVlanIpRanges (legacy) > >but for guestVlan dedication we have: > >dedicateGuestVlanRange >releaseDedicatedGuestVlanRange (releaseGuestVlanRange?) >listDedicatedGuestVlanRanges (listGuestVlanRanges? &account=<guest> >&domainid=<ROOT>) > >I'm purely looking at naming only, there's probably a reason why these are >named so. > >-- >Prasanna., > >------------------------ >Powered by BigRock.com
