I'll clean it up and submit a patch then.
Darren
On Sep 15, 2013, at 9:36 PM, Abhinandan Prateek
wrote:
> On 13/09/13 10:04 pm, "Darren Shepherd"
> wrote:
>
>> On 09/13/2013 03:48 AM, Abhinandan Prateek wrote:
>>> The code already has the name set to ³LDAP² in 4.2. What branch are you
>>> o
On 13/09/13 10:04 pm, "Darren Shepherd"
wrote:
>On 09/13/2013 03:48 AM, Abhinandan Prateek wrote:
>> The code already has the name set to ³LDAP² in 4.2. What branch are you
>>on
>> ?
>> Will also prefer if we can use getClass().getSimpleName() to get the
>> classname, but we should check the poss
On 09/12/2013 10:56 PM, Ian Duffy wrote:
So my problem is that LDAP currently has a null name on getName(). So
which should I do? Add
Go ahead and add it. I missed that override in error.
Okay I created https://reviews.apache.org/r/14126/
Darren
The code already has the name set to ³LDAP² in 4.2. What branch are you on
?
Will also prefer if we can use getClass().getSimpleName() to get the
classname, but we should check the possibility of the adapter classnames
getting enhanced by underlying framework.
On 13/09/13 4:41 am, "Darren Shephe
Great. Applied it.
You can mark it as submitted.
On 13 September 2013 16:10, Darren Shepherd wrote:
> On 09/12/2013 10:56 PM, Ian Duffy wrote:
>
>> So my problem is that LDAP currently has a null name on getName(). So
>>>
>> which should I do? Add
>>
>> Go ahead and add it. I missed that over
On 09/13/2013 03:48 AM, Abhinandan Prateek wrote:
The code already has the name set to ³LDAP² in 4.2. What branch are you on
?
Will also prefer if we can use getClass().getSimpleName() to get the
classname, but we should check the possibility of the adapter classnames
getting enhanced by underlyi
> So my problem is that LDAP currently has a null name on getName(). So
which should I do? Add
Go ahead and add it. I missed that override in error.
DefaultUserAuthenticator masks the _name variable in
ComponentLifecycleBase effectively making it so that no
UserAuthenticator gets the default name of getClass().getSimpleName().
Then each authenticator, except LDAP, does something like
if (name == null) {
name = "MD5";
}
So instead of the
