On 13/09/13 10:04 pm, "Darren Shepherd" <darren.s.sheph...@gmail.com> wrote:
>On 09/13/2013 03:48 AM, Abhinandan Prateek wrote: >> The code already has the name set to ³LDAP² in 4.2. What branch are you >>on >> ? >> Will also prefer if we can use getClass().getSimpleName() to get the >> classname, but we should check the possibility of the adapter classnames >> getting enhanced by underlying framework. >> > >I'm on master but that doesn't matter, its actually broke in 4.2 also. >I originally stated that the DefaultUserAuthenticator masks _name in >ComponentLifecycleBase so even though the XML is setting the property to >LDAP it doesn't work. That was sort of my original question, why was it >done like that? > >I can clean up all the authenticators and submit a patch if we want. > Looking at git history it appears that _name got masked when the DefaultUserAuthenticator was made to extend AdapterBase. A cleanup will help. -abhi >
