Re: PrimaryDataStoreEntityImpl TODOs

2013-06-28 Thread John Burwell
Prasanna, More irksome than forgetting to remove TODO comments after addressing them are TODOs that actually are TODOs and not cruft. The ticket referenced below us the later. I am fine with having an IDE generate them as a reminder to finish something. Contributors need to remember to address

Re: PrimaryDataStoreEntityImpl TODOs

2013-06-28 Thread Prasanna Santhanam
+1 The TODOs, @author tags and minor typos irks me too. Typos are understandable and I fix them when I see them. But it we should be keep the code clean of IDE introduced comments like TODOs. Please consider configuring your IDEs. Let's all _care_ for our codebase ... just a little. Now everyone

PrimaryDataStoreEntityImpl TODOs

2013-06-28 Thread John Burwell
All, While reviewing the solidfire patch, I noticed that a dummy getter/setter implementations with TODO comments in the PrimaryDataStoreImpl in were merged into master. I have opened a defect [1] for this issue, as the code will not work as expected (they are not actually working with the in