Build failed in Jenkins: cloudstack-4.3-forward-maven-build #184

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/184/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-83b (cloudstack-buildslave-cento

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #183

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/183/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-83b (cloudstack-buildslave-cento

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #182

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/182/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-83b (cloudstack-buildslave-cento

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #181

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/181/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-83b (cloudstack-buildslave-cento

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #180

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/180/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-e0d (cloudstack-buildslave-cento

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #179

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/179/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-e0d (cloudstack-buildslave-cento

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #178

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/178/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-e0d (cloudstack-buildslave-cento

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #177

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/177/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-e0d (cloudstack-buildslave-cento

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #176

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/176/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-e0d (cloudstack-buildslave-cento

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #175

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/175/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-e0d (cloudstack-buildslave-cento

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #174

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/174/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-e0d (cloudstack-buildslave-cento

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #173

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/173/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-e0d (cloudstack-buildslave-cento

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #172

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/172/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-e0d (cloudstack-buildslave-cento

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #171

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/171/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-e0d (cloudstack-buildslave-cento

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #170

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/170/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-e0d (cloudstack-buildslave-cento

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #169

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/169/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-e0d (cloudstack-buildslave-cento

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #168

2014-06-05 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/168/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-e0d (cloudstack-buildslave-cento

Jenkins build is back to normal : cloudstack-4.3-forward-maven-build #160

2014-04-11 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/160/changes>

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #159

2014-04-10 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/159/> -- [...truncated 2825 lines...] [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] Copying 3 resources [INFO]

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #158

2014-04-10 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/158/changes> Changes: [wido] CLOUDSTACK-4665: Depend on rados-java 0.1.4 [wido] CLOUDSTACK-4665: Check if a snapshot is protected before trying to unprotect -- [...tru

Jenkins build is back to normal : cloudstack-4.3-forward-maven-build #151

2014-03-17 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/151/changes>

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #150

2014-03-17 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/150/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-609 in workspace

RE: Differences between 4.3 and 4.3-forward

2014-03-14 Thread Animesh Chaturvedi
> -Original Message- > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] > Sent: Friday, March 14, 2014 7:43 AM > To: dev@cloudstack.apache.org > Subject: Re: Differences between 4.3 and 4.3-forward > > Yes, and we definitely cannot just take all of 4.3.1

Re: Differences between 4.3 and 4.3-forward

2014-03-14 Thread Mike Tutkowski
Yes, and we definitely cannot just take all of 4.3.1 and put it in 4.3 as many of those changes are intended for 4.3.1 and not 4.3. On Fri, Mar 14, 2014 at 8:40 AM, Sudha Ponnaganti < sudha.ponnaga...@citrix.com> wrote: > Yes - 4.3-forward is unstable branch and should be merged whi

RE: Differences between 4.3 and 4.3-forward

2014-03-14 Thread Sudha Ponnaganti
Yes - 4.3-forward is unstable branch and should be merged while 4.3 is going through RC. It is meant for maintenance release. -Original Message- From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: Friday, March 14, 2014 7:36 AM To: dev@cloudstack.apache.org Subject: Re

Re: Differences between 4.3 and 4.3-forward

2014-03-14 Thread Mike Tutkowski
@cloudstack.apache.org > Subject: RE: Differences between 4.3 and 4.3-forward > > Will these automatically go into 4.3.1, do we know if they've gone into > master as well? > > Otherwise does this mean we have a load of bug fixes which we're not > putting into 4.3.0 whic

RE: Differences between 4.3 and 4.3-forward

2014-03-14 Thread Sudha Ponnaganti
: Differences between 4.3 and 4.3-forward Will these automatically go into 4.3.1, do we know if they've gone into master as well? Otherwise does this mean we have a load of bug fixes which we're not putting into 4.3.0 which could potentially become orphaned in the 4.3-forward branch? (this qu

Re: Differences between 4.3 and 4.3-forward

2014-03-14 Thread Daan Hoogland
ng > into 4.3.0 which could potentially become orphaned in the 4.3-forward branch? > (this query may be just my ignorance regarding ACS branching) > > Regards, > > Paul Angus > Cloud Architect > S: +44 20 3603 0540 | M: +447711418784 | T: @CloudyAngus > paul.an...@sh

RE: Differences between 4.3 and 4.3-forward

2014-03-14 Thread Paul Angus
Will these automatically go into 4.3.1, do we know if they've gone into master as well? Otherwise does this mean we have a load of bug fixes which we're not putting into 4.3.0 which could potentially become orphaned in the 4.3-forward branch? (this query may be just my ignorance reg

Differences between 4.3 and 4.3-forward

2014-03-12 Thread Hugo Trippaers
Hey, There is a sizable number of differences between the two branch. Maybe it’s time to ditch 4.3-forward and recreate it based on current 4.3? Cheers, Hugo Hugos-MacBook-Pro:cloudstack hugo (4.3-forward)$ git diff --stat 4.3-forward 4.3 api/src/org/apache/cloudstack/api/command/user

Jenkins build is back to normal : cloudstack-4.3-forward-maven-build #141

2014-03-11 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/141/changes>

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #140

2014-03-11 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/140/> -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-1d6 in workspace

Jenkins build is back to normal : cloudstack-4.3-forward-maven-build #125

2014-03-04 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/125/changes>

Re: Build on 4.3-forward Fails: Shows Failure for Framework-Clustering

2014-03-02 Thread Nguyen Anh Tu
4.3 and there was some change for > java7 made to repo, during that time. > > Note, above may not be a true solution to the below problem, but it > worked. The local binaries are getting corrupted somehow it seems. > > > > Santhosh > >

Re: Build on 4.3-forward Fails: Shows Failure for Framework-Clustering

2014-03-02 Thread Koushik Das
I am facing a build failure but for a different reason on 4.3-forward. Looks like due to commit 065ac54bd7755cb44667c71311293c8f2110b3f3 Author: tuna Date: Sat Mar 1 11:36:27 2014 +0700 CLOUDSTACK-6162: add UI for OVS plugin [INFO

RE: Build on 4.3-forward Fails: Shows Failure for Framework-Clustering

2014-03-02 Thread Santhosh Edukulla
Santhosh From: ng.t...@gmail.com [ng.t...@gmail.com] on behalf of Nguyen Anh Tu [t...@apache.org] Sent: Monday, March 03, 2014 12:27 AM To: dev@cloudstack.apache.org Subject: RE: Build on 4.3-forward Fails: Shows Failure for Framework-Clustering Santhosh,

RE: Build on 4.3-forward Fails: Shows Failure for Framework-Clustering

2014-03-02 Thread Nguyen Anh Tu
mail using mobile) I have to fix my commit yesterday to 4.3-forward branch. --Tuna Sent from my GT-N7000 Thanks Santhosh! --Tuna Sent from my GT-N7000 On Mar 3, 2014 12:27 AM, "Santhosh Edukulla" wrote: > Tuna, > > I removed the packages under ~/.m2/repository/, up

RE: Build on 4.3-forward Fails: Shows Failure for Framework-Clustering

2014-03-02 Thread Nguyen Anh Tu
d only the problem jars from above path, but it didn't > worked. > > Santhosh > > From: ng.t...@gmail.com [ng.t...@gmail.com] on behalf of Nguyen Anh Tu [ > t...@apache.org] > Sent: Sunday, March 02, 2014 12:05 PM > To: dev@clouds

RE: Build on 4.3-forward Fails: Shows Failure for Framework-Clustering

2014-03-02 Thread Santhosh Edukulla
l.com [ng.t...@gmail.com] on behalf of Nguyen Anh Tu [t...@apache.org] Sent: Sunday, March 02, 2014 12:05 PM To: dev@cloudstack.apache.org Subject: Re: Build on 4.3-forward Fails: Shows Failure for Framework-Clustering Am also facing this issue too. Anyone can help? --Tuna On Thu, Jan 23, 2014

Re: Build on 4.3-forward Fails: Shows Failure for Framework-Clustering

2014-03-02 Thread Nguyen Anh Tu
ku...@citrix.com] > Sent: Thursday, January 23, 2014 1:20 PM > To: dev@cloudstack.apache.org > Subject: Build on 4.3-forward Fails: Shows Failure for Framework-Clustering > > Team, > > 1. We are seeing a build failure for latest 4.3-forward branch code. Below > is the error

Re: Difference between 4.3 and 4.3-forward?

2014-03-01 Thread Nux!
On 01.03.2014 23:27, Marcus wrote: 4.3-forward is where commits go that you want to eventually end up in 4.3.x, whether it be another RC build or a maintenance release (4.3.1). Then the release manager approves and pulls into 4.3, or when 4.3 is released pulls all of 4.3-forward back into 4.3

Re: Difference between 4.3 and 4.3-forward?

2014-03-01 Thread Animesh Chaturvedi
4.3 is the branch from which I build RCs. 4.3-forward is temporary staging branch where folks post fixes for issues. I pick up critical issues needed from there into 4.3. Once 4.3 GAs i will merge 4.3-forward into 4.3 and delete the forward branch. Thanks Animesh On Mar 1, 2014, at 10:40 AM

Re: Difference between 4.3 and 4.3-forward?

2014-03-01 Thread Marcus
4.3-forward is where commits go that you want to eventually end up in 4.3.x, whether it be another RC build or a maintenance release (4.3.1). Then the release manager approves and pulls into 4.3, or when 4.3 is released pulls all of 4.3-forward back into 4.3 for the next release going forard. On

Difference between 4.3 and 4.3-forward?

2014-03-01 Thread Nux!
Hi, What's the difference between 4.3 and 4.3-forward. From which will the official 4.3 release be build? Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #124

2014-03-01 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/124/> -- [...truncated 410 lines...] [INFO] Nullcheck of sc at line 432 of value previously dereferenced in com.cloud.utils.db.GenericDaoBase.customSearchIncludingR

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #123

2014-03-01 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/123/changes> Changes: [ng.tuna] CLOUDSTACK-6162: add UI for OVS plugin -- [...truncated 18680 lines...] [INFO] --- maven-resources-plugin:2.5:testResources (default-testRes

Re: FYI: 4.3 and 4.3-forward branches not building

2014-02-26 Thread Sebastien Goasguen
On Feb 26, 2014, at 1:31 PM, John Kinsella wrote: > Before we go to another vote - apidocs build is failing with: > > Traceback (most recent call last): > File "/home/jlk/code/cloudstack/tools/apidoc/gen_toc.py", line 195, in > >category = choose_category(fn) > File "/home/jlk/code/clou

FYI: 4.3 and 4.3-forward branches not building

2014-02-26 Thread John Kinsella
Before we go to another vote - apidocs build is failing with: Traceback (most recent call last): File "/home/jlk/code/cloudstack/tools/apidoc/gen_toc.py", line 195, in category = choose_category(fn) File "/home/jlk/code/cloudstack/tools/apidoc/gen_toc.py", line 175, in choose_category

Re: [Merge]Please cherry pick below commits from 4.3 to 4.3-forward

2014-02-25 Thread Mike Tutkowski
Ah :) That makes sense then. On Tue, Feb 25, 2014 at 5:38 PM, Animesh Chaturvedi < animesh.chaturv...@citrix.com> wrote: > > He meant the other way. > > > Thanks > Animesh > -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Adva

Re: [Merge]Please cherry pick below commits from 4.3 to 4.3-forward

2014-02-25 Thread Animesh Chaturvedi
He meant the other way. Thanks Animesh

Re: [Merge]Please cherry pick below commits from 4.3 to 4.3-forward

2014-02-25 Thread Mike Tutkowski
Just curious about cherry picking here. I was under the impression we only send requests to cherry pick from, say, 4.3-forward to 4.3 and that going from 4.3 to 4.3-forward does not require such a request. On Tue, Feb 25, 2014 at 3:04 PM, Frank Zhang wrote: > com

[Merge]Please cherry pick below commits from 4.3 to 4.3-forward

2014-02-25 Thread Frank Zhang
commit 20efa0c8a6b83c6590eab48fefac81b72b2082a9 Author: Frank.Zhang Date: Mon Feb 24 13:30:24 2014 -0800 CLOUDSTACK-6155 Baremetal agent RPM missing in spec file commit c1806bd873fe661756aeee94b25339c25f9724a5 Author: Frank.Zhang Date: Fri Feb 21 13:22:55 2014 -0800 CLOUDSTACK-

Re: Findbugs report on 4.3-forward

2014-02-03 Thread Daan Hoogland
On Mon, Feb 3, 2014 at 7:55 AM, Rajani Karuturi wrote: > you please do it on 4.3-forward and master as well. I'll do it on 4.3-forward and I'll be on all findbugs issues on master so it'll pass by automatically

Re: Findbugs report on 4.3-forward

2014-02-02 Thread Rajani Karuturi
Hi Daan/Ian, looks like the change is only in 4.3. Can you please do it on 4.3-forward and master as well. Thanks, ~Rajani On 03-Feb-2014, at 12:21 am, Daan Hoogland wrote: > just pushed :( > > > On Sun, Feb 2, 2014 at 7:50 PM, Ian Duffy wrote: >> Daan, >> &

Re: Findbugs report on 4.3-forward

2014-02-02 Thread Daan Hoogland
, 2014 at 6:52 PM, Rajani Karuturi >> wrote: >> > Sure Daan. Will submit a review request for master and 4.3-forward >> tomorrow morning IST. >> > >> > Thanks, >> > ~Rajani >> > >> > >> > >> > On 02-Feb-2014, at 8:17

Re: Findbugs report on 4.3-forward

2014-02-02 Thread Ian Duffy
Daan, Have this done already, just about to push. On 2 February 2014 18:47, Daan Hoogland wrote: > never mind, I thought you are committer. I'll fix > > On Sun, Feb 2, 2014 at 6:52 PM, Rajani Karuturi > wrote: > > Sure Daan. Will submit a review request for master and

Re: Findbugs report on 4.3-forward

2014-02-02 Thread Daan Hoogland
never mind, I thought you are committer. I'll fix On Sun, Feb 2, 2014 at 6:52 PM, Rajani Karuturi wrote: > Sure Daan. Will submit a review request for master and 4.3-forward tomorrow > morning IST. > > Thanks, > ~Rajani > > > > On 02-Feb-2014, at 8:17 pm, Daan H

Re: Findbugs report on 4.3-forward

2014-02-02 Thread Rajani Karuturi
Sure Daan. Will submit a review request for master and 4.3-forward tomorrow morning IST. Thanks, ~Rajani On 02-Feb-2014, at 8:17 pm, Daan Hoogland wrote: > On Sun, Feb 2, 2014 at 12:48 PM, Rajani Karuturi > wrote: >> what we should use is new String(bytes[]) > > >

Re: Findbugs report on 4.3-forward

2014-02-02 Thread Daan Hoogland
On Sun, Feb 2, 2014 at 12:48 PM, Rajani Karuturi wrote: > what we should use is new String(bytes[]) ok, makes sense. Can you revert my commit and make a new patch? thanks, Daan

Re: Findbugs report on 4.3-forward

2014-02-02 Thread Rajani Karuturi
ommand/LdapCreateAccountCmd.java and in all the branches master, 4.3-forward, 4.3 regarding the encoding issue, The initial version wasn’t storing the random string directly in db but a base64 encoded one(at least it was trying to do that and had a bug). For example, abcdef would become YWJjZGVm. With th

Re: Findbugs report on 4.3-forward

2014-02-01 Thread Sebastien Goasguen
imesh, >>>>>>>>> >>>>>>>>> Tested all those changes to detail. Those lines were removed due to >>>>>>>>> unexpected behavior that I had not spotted until now. >>>>>>>>> >>>>>>>>&

Re: Findbugs report on 4.3-forward

2014-01-31 Thread Ian Duffy
t; >> if a > >>>>>>> users password was reset in LDAP the old password was still > allowing > >> login > >>>>>>> for a limited time. > >>>>>>> > >>>>>>> Please pull the changes

Re: Findbugs report on 4.3-forward

2014-01-30 Thread Rajani Karuturi
t;>>>>> for a limited time. >>>>>>> >>>>>>> Please pull the changes forward, >>>>>>> Thanks >>>>>>> >>>>>>> Ian. >>>>>>> On 29 Jan 2014 00:07, "Animesh Chaturvedi" <

Re: Findbugs report on 4.3-forward

2014-01-30 Thread Ian Duffy
t;>>>> wrote: > >>>>> > >>>>>> If I look at this commit for example > >>>>>> > >>>>>> > >>>>>> > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit

Re: Findbugs report on 4.3-forward

2014-01-30 Thread Daan Hoogland
t;>>> environment.put("com.sun.jndi.ldap.connect.pool", "true"); >>>>>> >>>>>> Is that reported by find bug? I don't know this code so not sure if it >>>>>> is >>>>>> int

Re: Findbugs report on 4.3-forward

2014-01-30 Thread Daan Hoogland
t; >>>>> It removes the two lines from LdapContextFactory.java >>>>> >>>>> environment.put("com.sun.jndi.ldap.read.timeout", "500");- >>>>> environment.put("com.sun.jndi.ldap.connect.pool", "true")

Re: Findbugs report on 4.3-forward

2014-01-30 Thread Daan Hoogland
ut("com.sun.jndi.ldap.connect.pool", "true"); >>>> >>>> Is that reported by find bug? I don't know this code so not sure if it is >>>> intentional or not ? >>>> >>>> The point is there may be unintended risks in allowi

Re: Findbugs report on 4.3-forward

2014-01-29 Thread Rajani Karuturi
by find bug? I don’t know this code so not sure if it is >>> intentional or not ? >>> >>> The point is there may be unintended risks in allowing late changes. >>> >>> >>> >>> -Original Message- >>> From: Ani

RE: Findbugs report on 4.3-forward

2014-01-29 Thread Animesh Chaturvedi
-Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Wednesday, January 29, 2014 1:06 PM To: dev; Animesh Chaturvedi Subject: Re: Findbugs report on 4.3-forward H Animesh, I am done cherry-picking, compiling and pushing. [Animesh] Cool, I will also need to

Re: Findbugs report on 4.3-forward

2014-01-29 Thread Daan Hoogland
H Animesh, I am done cherry-picking, compiling and pushing. I wonder if now is opportune to build a new rc. shouldn't we wait till more people have tested? I for instance (doing a quarter of the test plans that we have at Schuberg Philis) ran into some issues and am not sure yet if they are in th

Re: Findbugs report on 4.3-forward

2014-01-29 Thread Daan Hoogland
On Wed, Jan 29, 2014 at 9:50 PM, Daan Hoogland wrote: > and will the push and will then push

Re: Findbugs report on 4.3-forward

2014-01-29 Thread Daan Hoogland
On Wed, Jan 29, 2014 at 9:36 PM, Animesh Chaturvedi wrote: > [Animesh] I know but at this time we need closer scrutiny and just the > specific change helps in that. There was a similar comment in private when > some of us were reviewing security patches. point taken I am not cherry picking the

RE: Findbugs report on 4.3-forward

2014-01-29 Thread Animesh Chaturvedi
-Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Wednesday, January 29, 2014 12:14 PM To: dev Subject: Re: Findbugs report on 4.3-forward On Wed, Jan 29, 2014 at 8:48 PM, Animesh Chaturvedi wrote: > Instant gratification on fixing something is trump

Re: Findbugs report on 4.3-forward

2014-01-29 Thread Daan Hoogland
nesday, January 29, 2014 8:47 AM > To: dev > Subject: Re: Findbugs report on 4.3-forward > > The first five I allready posted. The ones between brackets seem minor to me. > Then again they also pose the least risk so in my opinion you should pull > them all. The last one is a bug

Re: Findbugs report on 4.3-forward

2014-01-29 Thread Daan Hoogland
On Wed, Jan 29, 2014 at 8:48 PM, Animesh Chaturvedi wrote: > Instant gratification on fixing something is trumping managing risk. I don't think I like the implication of that remark. I am sure you mean well and are tired. > The patches are littered with formatting changes that make review > time

Re: Findbugs report on 4.3-forward

2014-01-29 Thread Daan Hoogland
good point Mike, I would like to add that in our case 'quality' means 'usability'. We are not writing military or madical grade code. However I don't want to tell a big far eastern telco that their it is out because i left an == in the code that was meant to be an equals() call, or a leak because

RE: Findbugs report on 4.3-forward

2014-01-29 Thread Animesh Chaturvedi
build another RC today. Animesh -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Wednesday, January 29, 2014 8:47 AM To: dev Subject: Re: Findbugs report on 4.3-forward The first five I allready posted. The ones between brackets seem minor to me. Then again

RE: Findbugs report on 4.3-forward

2014-01-29 Thread Animesh Chaturvedi
-Original Message- From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: Wednesday, January 29, 2014 11:15 AM To: dev@cloudstack.apache.org Subject: Re: Findbugs report on 4.3-forward I agree that quality should be our primary focus. [Animesh] No one would disagree that

Re: Findbugs report on 4.3-forward

2014-01-29 Thread Mike Tutkowski
I agree that quality should be our primary focus. My one point of caution here would be, "How risky are these fixes?" Just because we believe we have fixes for issues does not necessarily mean they should be put in a release late in the game. We have to weigh the benefits of having the fixes versu

Re: Findbugs report on 4.3-forward

2014-01-29 Thread Chip Childers
On Tue, Jan 28, 2014 at 11:36:52PM +0100, Hugo Trippaers wrote: > Hey Animesh, > > Not in agreement here. These are squashed bugs and we want as less bugs in > the release as possible. > > This is why we test any RC before we release it. I say include all the big > fixes we have in the release.

Re: Findbugs report on 4.3-forward

2014-01-29 Thread Daan Hoogland
please pull d38a50343130f6f147e2c9c7b2e32a43f31c7e6b to 4.3 this one came out of our regression testing, I hope other people are keeping up the testing as well in spite of all the discussion on the RC!!! thanks for your patience Animesh, Daan On Wed, Jan 29, 2014 at 5:55 PM, Daan Hoogland wrote

Jenkins build is back to normal : cloudstack-4.3-forward-maven-build #33

2014-01-29 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/33/changes>

Re: Findbugs report on 4.3-forward

2014-01-29 Thread Daan Hoogland
On Wed, Jan 29, 2014 at 5:47 PM, Daan Hoogland wrote: > and > > caf17c2f46bf317ec8966b08aaff728a73fda14a never mind that last one, i was in a hury and screwed up. will revert

Build failed in Jenkins: cloudstack-4.3-forward-maven-build #32

2014-01-29 Thread jenkins
See <http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/32/changes> Changes: [Daan Hoogland] CLOUDSTACK-5979 vlan parsing fixed -- [...truncated 3436 lines...]

Re: Findbugs report on 4.3-forward

2014-01-29 Thread Daan Hoogland
d local vars. This doesn't seem vital >>> (or dangerous) but pulling only one seems very few. >>> >>> >>> On Wed, Jan 29, 2014 at 7:11 AM, Animesh Chaturvedi >>> wrote: >>>> >>>> >>>> -Original Message- >>

Re: Findbugs report on 4.3-forward

2014-01-29 Thread Animesh Chaturvedi
gt;>> >>> -Original Message- >>> From: Ian Duffy [mailto:i...@ianduffy.ie] >>> Sent: Tuesday, January 28, 2014 6:34 PM >>> To: CloudStack Dev >>> Subject: RE: Findbugs report on 4.3-forward >>> >>> Hi Animesh, >>>

Re: Findbugs report on 4.3-forward

2014-01-29 Thread Daan Hoogland
, Animesh Chaturvedi > wrote: >> >> >> -Original Message- >> From: Ian Duffy [mailto:i...@ianduffy.ie] >> Sent: Tuesday, January 28, 2014 6:34 PM >> To: CloudStack Dev >> Subject: RE: Findbugs report on 4.3-forward >> >> Hi Animesh, >>

Re: Findbugs report on 4.3-forward

2014-01-29 Thread Daan Hoogland
- > From: Ian Duffy [mailto:i...@ianduffy.ie] > Sent: Tuesday, January 28, 2014 6:34 PM > To: CloudStack Dev > Subject: RE: Findbugs report on 4.3-forward > > Hi Animesh, > > Tested all those changes to detail. Those lines were removed due to > unexpected behavior that I had not

RE: Findbugs report on 4.3-forward

2014-01-28 Thread Animesh Chaturvedi
-Original Message- From: Ian Duffy [mailto:i...@ianduffy.ie] Sent: Tuesday, January 28, 2014 6:34 PM To: CloudStack Dev Subject: RE: Findbugs report on 4.3-forward Hi Animesh, Tested all those changes to detail. Those lines were removed due to unexpected behavior that I had not

Re: Findbugs report on 4.3-forward

2014-01-28 Thread Rajani Karuturi
A quick look at 20+ commits from >> Daan show many formatting changes that may not be necessary and hinder >> quick review. >> >> -Original Message- >> From: Hugo Trippaers [mailto:trip...@gmail.com] >> Sent: Tuesday, January 28, 2014 3:16 PM >>

RE: Findbugs report on 4.3-forward

2014-01-28 Thread Ian Duffy
m] > Sent: Tuesday, January 28, 2014 3:35 PM > To: dev@cloudstack.apache.org > Subject: RE: Findbugs report on 4.3-forward > > Are you sure all of the ones are needed. A quick look at 20+ commits from > Daan show many formatting changes that may not be necessary and hinder > qu

RE: Findbugs report on 4.3-forward

2014-01-28 Thread Animesh Chaturvedi
imesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] Sent: Tuesday, January 28, 2014 3:35 PM To: dev@cloudstack.apache.org Subject: RE: Findbugs report on 4.3-forward Are you sure all of the ones are needed. A quick look at 20+ commits from Daan show many formatting changes that may not be necessary

RE: Findbugs report on 4.3-forward

2014-01-28 Thread Animesh Chaturvedi
@cloudstack.apache.org Subject: Re: Findbugs report on 4.3-forward Sent from my iPhone > On 28 jan. 2014, at 23:50, Animesh Chaturvedi > wrote: > > > -Original Message- > From: Hugo Trippaers [mailto:trip...@gmail.com] > Sent: Tuesday, January 28, 2014 2:37 PM > To: dev@cl

RE: VM instance view UI is broken in 4.3-forward (This is an API bug, not UI bug. )

2014-01-28 Thread Jessica Wang
Koushik, I just tested in 4.3-forward branch. This is an API bug, not UI bug. (1) "virtualmachine" object returned by deployVirtualMachine API, queryAsyncJobResult API does NOT include name, displayname, zonename, state property. http://10.215.3.26:8080/client/a

Re: Findbugs report on 4.3-forward

2014-01-28 Thread Hugo Trippaers
org > Subject: Re: Findbugs report on 4.3-forward > > Hey Animesh, > > Not in agreement here. These are squashed bugs and we want as less bugs in > the release as possible. > [Animesh] I understand but once we enter RC phase we only limit important > fixes. I have pu

RE: Findbugs report on 4.3-forward

2014-01-28 Thread Animesh Chaturvedi
-Original Message- From: Hugo Trippaers [mailto:trip...@gmail.com] Sent: Tuesday, January 28, 2014 2:37 PM To: dev@cloudstack.apache.org Cc: dev@cloudstack.apache.org Subject: Re: Findbugs report on 4.3-forward Hey Animesh, Not in agreement here. These are squashed bugs and we want as

Re: Findbugs report on 4.3-forward

2014-01-28 Thread Hugo Trippaers
h he called -1. > > Thanks > Animesh > > -Original Message- > From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers > Sent: Tuesday, January 28, 2014 1:29 AM > To: dev > Subject: Re: Findbugs report on 4.3-forward > > Hey Animesh, > > I

Re: Findbugs report on 4.3-forward

2014-01-28 Thread Daan Hoogland
Of Hugo Trippaers > Sent: Tuesday, January 28, 2014 1:29 AM > To: dev > Subject: Re: Findbugs report on 4.3-forward > > Hey Animesh, > > I agree with Daan here. We focussed on the bugs with a findbugs annotation of > scariest. I think that would warrant them to be includ

RE: Findbugs report on 4.3-forward

2014-01-28 Thread Animesh Chaturvedi
Hugo's commit for which he called -1. Thanks Animesh -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Tuesday, January 28, 2014 1:29 AM To: dev Subject: Re: Findbugs report on 4.3-forward Hey Animesh, I agree with Daan here. We focussed o

Re: Findbugs report on 4.3-forward

2014-01-28 Thread Rajani Karuturi
less secure than the previous one. Thanks, ~Rajani On 28-Jan-2014, at 10:55 am, Ian Duffy mailto:i...@ianduffy.ie>> wrote: Hi Animesh, Can you cherry-pick the below commit from from 4.3-forward to 4.3 branch? Fix findbug issues within LDAP authenticator commit 92b4f66d73562e4211d2d7

  1   2   >