Re: [PR] Add missing API calls for Cloudstack 4.20 [cloudstack-go]

2024-12-16 Thread via GitHub
DaanHoogland merged PR #91: URL: https://github.com/apache/cloudstack-go/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudst

Re: [PR] Add missing API calls for Cloudstack 4.20 [cloudstack-go]

2024-12-16 Thread via GitHub
Pearl1594 commented on PR #91: URL: https://github.com/apache/cloudstack-go/pull/91#issuecomment-2546826849 Thanks @phsm - tests now run successfully! Thank you :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Add missing API calls for Cloudstack 4.20 [cloudstack-go]

2024-12-16 Thread via GitHub
phsm commented on PR #91: URL: https://github.com/apache/cloudstack-go/pull/91#issuecomment-2545978224 @Pearl1594 This was to tidy up an abandoned https://github.com/golang/mock/ package. The authors there suggest to switch to a maintained fork instead. I replaced the rest of the

Re: [PR] Add missing API calls for Cloudstack 4.20 [cloudstack-go]

2024-12-16 Thread via GitHub
phsm commented on code in PR #91: URL: https://github.com/apache/cloudstack-go/pull/91#discussion_r1887053442 ## generate/layout.go: ## @@ -790,16 +864,92 @@ var layout = apiInfo{ "RegistrationService": { "registerOauthProvider", }, - "Shutd

Re: [PR] Add missing API calls for Cloudstack 4.20 [cloudstack-go]

2024-12-16 Thread via GitHub
Pearl1594 commented on PR #91: URL: https://github.com/apache/cloudstack-go/pull/91#issuecomment-2545895377 For some reason, the tests seem to fail on this PR - @phsm can you please help us with this: I needed to make the following changes to make it work - I am not sure why the 1st two

Re: [PR] Add missing API calls for Cloudstack 4.20 [cloudstack-go]

2024-12-16 Thread via GitHub
Pearl1594 commented on code in PR #91: URL: https://github.com/apache/cloudstack-go/pull/91#discussion_r1886985264 ## generate/layout.go: ## @@ -790,16 +864,92 @@ var layout = apiInfo{ "RegistrationService": { "registerOauthProvider", }, - "

Re: [PR] Add missing API calls for Cloudstack 4.20 [cloudstack-go]

2024-12-16 Thread via GitHub
phsm commented on PR #91: URL: https://github.com/apache/cloudstack-go/pull/91#issuecomment-2545574592 @DaanHoogland updated both the code, and the PR header/description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use