Pearl1594 commented on PR #91:
URL: https://github.com/apache/cloudstack-go/pull/91#issuecomment-2545895377
For some reason, the tests seem to fail on this PR - @phsm can you please
help us with this:
I needed to make the following changes to make it work - I am not sure why
the 1st two changes are required, as it isn't required upstream:
```
diff --git a/Makefile b/Makefile
index 015bba8..33ad3ea 100644
--- a/Makefile
+++ b/Makefile
@@ -27,4 +27,4 @@ test:
MOCKGEN := mockgen
mockgen: ## Download conversion-gen locally if necessary.
- go get github.com/golang/mock/mockgen; go install
github.com/golang/mock/mockgen;
+ go get go.uber.org/mock/mockgen; go install go.uber.org/mock/mockgen;
```
examples/mock_test.go file
```
diff --git a/examples/mock_test.go b/examples/mock_test.go
index b965c3a..da50adb 100644
--- a/examples/mock_test.go
+++ b/examples/mock_test.go
@@ -23,7 +23,7 @@ import (
"testing"
"github.com/apache/cloudstack-go/v2/cloudstack"
- "github.com/golang/mock/gomock"
+ "go.uber.org/mock/gomock"
)
func Test_Mock(t *testing.T) {
```
layout.go
```
git diff generate/layout.go
diff --git a/generate/layout.go b/generate/layout.go
index d399ba9..2271abb 100644
--- a/generate/layout.go
+++ b/generate/layout.go
@@ -864,6 +864,9 @@ var layout = apiInfo{
"RegistrationService": {
"registerOauthProvider",
},
+ "ShutdownService": {
+ "readyForShutdown",
+ },
"DiagnosticsService": {
"getDiagnosticsData",
"runDiagnostics",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
