Re: [MERGE] resize-root branch

2014-03-18 Thread Min Chen
Verified your fix, my IAM test passed. Thanks for the fix, Marcus. -min On 3/17/14 10:39 PM, "Marcus" wrote: >This commit in 4.4 should fix it (cherry picked to master as well): > >commit 8eed3c5113d1141be820077e121db802566faec6 >Author: Marcus Sorensen >Date: Fri Mar 14 07:13:34 2014 -0600

Re: [MERGE] resize-root branch

2014-03-18 Thread Min Chen
Yes, that is the root cause for the failure. Thanks -min On 3/17/14 10:26 PM, "Marcus" wrote: >Looks like all of the items in 'details' are getting added to the API >call as empty params: > >GET >/client/api?domainid=7193957c-ab53-11e3-a79c-000c29d82947&zoneid=bfc93d0d- >9531-4648-9d04-ca1f47f

Re: [MERGE] resize-root branch

2014-03-18 Thread Min Chen
Thanks -min On 3/17/14 10:39 PM, "Marcus" wrote: >This commit in 4.4 should fix it (cherry picked to master as well): > >commit 8eed3c5113d1141be820077e121db802566faec6 >Author: Marcus Sorensen >Date: Fri Mar 14 07:13:34 2014 -0600 > >Change newly added details map for deployVirtualMachin

Re: [MERGE] resize-root branch

2014-03-17 Thread Marcus
This commit in 4.4 should fix it (cherry picked to master as well): commit 8eed3c5113d1141be820077e121db802566faec6 Author: Marcus Sorensen Date: Fri Mar 14 07:13:34 2014 -0600 Change newly added details map for deployVirtualMachine to an empty map, instead of passing all possible keys

Re: [MERGE] resize-root branch

2014-03-17 Thread Marcus
Looks like all of the items in 'details' are getting added to the API call as empty params: GET /client/api?domainid=7193957c-ab53-11e3-a79c-000c29d82947&zoneid=bfc93d0d-9531-4648-9d04-ca1f47fcd5a6&apiKey=8d6jxAVly_B6asBBjuL5S5bxXzNhx3CyiPLCJQ7Qa4hti3HLlQQkP-x-ayenmO6t8vfZt5nDRHixsJc7XKdIGA&detai

Re: [MERGE] resize-root branch

2014-03-17 Thread Marcus
I'll take a look. I wasn't the one who added the details map to base.py, although I did add to it and can probably figure out what's wrong. The original commit didn't change any deployVirtualMachine calls. Can you give me an example of a test that is faling? Is it test_deploy_vm.py? On Mon, Mar 17

Re: [MERGE] resize-root branch

2014-03-17 Thread Min Chen
Hi Marcus, I found an issue with this merge, my previous marvin test is broken in deployVirtualMachine if no rootdisksize is passed. All previous marvin tests are written without passing this parameter. Can you take a look at base.py to make sure that old marvin tests without passing those

Re: [MERGE] resize-root branch

2014-03-12 Thread Nux!
On 11.03.2014 20:17, Marcus wrote: I'd like to merge the resize-root branch for the requested feature of being able to resize root volumes. I have pulled from master and tested. I should note that this feature is affected by an existing bug in master that was introduced recently, breaking the ex

[MERGE] resize-root branch

2014-03-11 Thread Marcus
I'd like to merge the resize-root branch for the requested feature of being able to resize root volumes. I have pulled from master and tested. I should note that this feature is affected by an existing bug in master that was introduced recently, breaking the existing data disk resize feature on Ub