Hi Marcus,
I found an issue with this merge, my previous marvin test is broken in
deployVirtualMachine if no rootdisksize is passed. All previous marvin
tests are written without passing this parameter. Can you take a look at
base.py to make sure that old marvin tests without passing those custom
parameters are still working fine?
Thanks
-min
On 3/11/14 1:17 PM, "Marcus" <shadow...@gmail.com> wrote:
>I'd like to merge the resize-root branch for the requested feature of
>being able to resize root volumes. I have pulled from master and
>tested.
>
>I should note that this feature is affected by an existing bug in
>master that was introduced recently, breaking the existing data disk
>resize feature on Ubuntu 12.04 + stock libvirt, but has otherwise been
>tested to work with Ubuntu 12.04 + recent libvirt and CentOS 6.4,6.5.
>We are discussing how to proceed with that separate issue on-list.
>
>Integration tests were added for deploy in a new file
>"test_deploy_vm_root_resize.py" and existing resize tests were
>extended to root volumes in the existing test_volumes.py.
>
>Findbugs indicates there are no new issues introduced (220/220), as
>reported by running the following on both master and resize-root. This
>was just my stab in the dark at trying to make sense of the output in
>absence of familiarity with findbugs:
>
># mvn -P enablefindbugs verify
># find . -name findbugs.xml -exec xmllint --format {} \; | grep -c
>BugInstance
>
>FS:
>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Root+Resize+Support
>JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-6181
