Re: [MERGE] Dedicate guest vlan ranges to account

2013-05-08 Thread Prasanna Santhanam
On Wed, May 08, 2013 at 06:10:11AM +, Likitha Shetty wrote: > Prasanna, fixed the error. > > About the API naming of commands related to guest vlan range dedication, the > API names were chosen to be consistent with the commands related to > dedication of other resources (Host, Pod, Cluster

RE: [MERGE] Dedicate guest vlan ranges to account

2013-05-07 Thread Likitha Shetty
g] >Sent: Tuesday, May 07, 2013 3:37 PM >To: dev@cloudstack.apache.org >Subject: Re: [MERGE] Dedicate guest vlan ranges to account > >On Mon, May 06, 2013 at 08:52:38AM +, Likitha Shetty wrote: >> Thanks for reviewing. >> Merged in to master - c8d843241e144288300c191

Re: [MERGE] Dedicate guest vlan ranges to account

2013-05-07 Thread Prasanna Santhanam
On Mon, May 06, 2013 at 08:52:38AM +, Likitha Shetty wrote: > Thanks for reviewing. > Merged in to master - c8d843241e144288300c1912a25b201e010bb7a0. > I tried to run your test but looks like the AccessChecks weren't in place for your APIs. Since these are admin (?) APIs I've put them into co

RE: [MERGE] Dedicate guest vlan ranges to account

2013-05-06 Thread Likitha Shetty
gt; From: Likitha Shetty [mailto:likitha.she...@citrix.com] >> > Sent: Thursday, May 02, 2013 12:28 PM >> > To: dev@cloudstack.apache.org >> > Subject: RE: [MERGE] Dedicate guest vlan ranges to account >> > >> > Updated branch dedicate-guest

Re: [MERGE] Dedicate guest vlan ranges to account

2013-05-06 Thread Prasanna Santhanam
hursday, May 02, 2013 12:28 PM > > To: dev@cloudstack.apache.org > > Subject: RE: [MERGE] Dedicate guest vlan ranges to account > > > > Updated branch dedicate-guest-vlan-ranges_2 with the suggested changes. > > > > Thanks, > > Likitha > > > > &g

RE: [MERGE] Dedicate guest vlan ranges to account

2013-05-02 Thread Hugo Trippaers
Looks good to me +1 to merge Cheers, Hugo > -Original Message- > From: Likitha Shetty [mailto:likitha.she...@citrix.com] > Sent: Thursday, May 02, 2013 12:28 PM > To: dev@cloudstack.apache.org > Subject: RE: [MERGE] Dedicate guest vlan ranges to account > > Up

RE: [MERGE] Dedicate guest vlan ranges to account

2013-05-02 Thread Likitha Shetty
Updated branch dedicate-guest-vlan-ranges_2 with the suggested changes. Thanks, Likitha >-Original Message- >From: Likitha Shetty [mailto:likitha.she...@citrix.com] >Sent: Thursday, May 02, 2013 10:58 AM >To: dev@cloudstack.apache.org >Subject: RE: [MERGE] Dedicate guest

RE: [MERGE] Dedicate guest vlan ranges to account

2013-05-01 Thread Likitha Shetty
e without any changes in the file itself). Can you fix that? Permissions >should >be 644 for java code. > >Cheers, > >Hugo > >> -Original Message- >> From: Likitha Shetty [mailto:likitha.she...@citrix.com] >> Sent: Wednesday, May 01, 2013 12:39 PM >

RE: [MERGE] Dedicate guest vlan ranges to account

2013-05-01 Thread Hugo Trippaers
644 for java code. Cheers, Hugo > -Original Message- > From: Likitha Shetty [mailto:likitha.she...@citrix.com] > Sent: Wednesday, May 01, 2013 12:39 PM > To: dev@cloudstack.apache.org > Subject: [MERGE] Dedicate guest vlan ranges to account > > Hi all, > >

[MERGE] Dedicate guest vlan ranges to account

2013-05-01 Thread Likitha Shetty
Hi all, I would like to merge the feature Dedicate Guest VLAN range to master. Jira ticket - https://issues.apache.org/jira/browse/CLOUDSTACK-704 FS - https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS-+Dedicate+Guest+VLANs+per+tenant Branch - dedicate-guest-vlan-ranges_2 (was develope