[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1019 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-158753796 Since the commits changed I run the tests again. Still LGTM. ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_h

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-154403803 Did run the tests before, forgot to post them. LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ```

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-153681753 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-153579131 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-152998269 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-152982076 @karuturi at your service --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1019#discussion_r43614066 --- Diff: plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java --- @@ -296,7 +296,7 @@ private void setHttpHeade

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-152976291 though its beyond what this PR want to fix, maybe we could fix L403(hash == HASH_CONFLICT) and L406(hash != HASH_IGNORE) as well. --- If your project is set u

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1019#discussion_r43612367 --- Diff: plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java --- @@ -296,7 +296,7 @@ private void setHttpHeader(fi

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1019#discussion_r43609915 --- Diff: plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java --- @@ -296,7 +296,7 @@ private void setHttpHeade

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1019#discussion_r43605823 --- Diff: plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java --- @@ -296,7 +296,7 @@ private void setHttpHeader(fi

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1019#discussion_r43602513 --- Diff: plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java --- @@ -296,7 +296,7 @@ private void setHttpHeade

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-152939410 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1019#discussion_r43601287 --- Diff: plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java --- @@ -296,7 +296,7 @@ private void setHttpHeader(fi

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1019 findbugs: ! equals instead of != simple pmd warning fixed You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack PMD