Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/709
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132145283
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132140803
@karuturi You should send a public key which has it's special characters (
SPACE / - % ) replaced with uri compatible escape characters. -> encoding
http://www.w3
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132123648
@karuturi go to the Accounts page, and select "SSH Key pairs" in the
dropdown.
---
If your project is set up for it, you can reply to this email and have your
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132121577
@milamberspace, I couldnt find registerSSHKeyPair from UI. I could only see
reset ssh key on a stopped vm. Where is this option in UI?
---
If your project is set u
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132121319
@borisroman excluding the cloudmonkey bit, if I make direct api call,
should I send the encoded value or the original value. Did that change from
previous version?
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132106862
@karuturi Cloudmonkey passes an single encoded public key, as it's supposed
to!
---
If your project is set up for it, you can reply to this email and have your
r
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132102845
LGTM.
I made the commit two years ago. However, something changed in the
following commit, so the encoding on UI is not needed any more.
com
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132097225
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132072846
so, the double encoding and double decoding lived happily together :)
Now, jquery does the encoding from UI and decoding is done in
ApiServlet.processRequestInC
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132072731
@borisroman does backend do double decoding? there was a patch for
cloudmonkey regarding this:
https://github.com/apache/cloudstack-cloudmonkey/commit/6bd92395592c1
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-131968267
It was double encoded because encodeURIComponent() and jQuery.param()
encoded it. The latter does this automatically because the request is of type
post and the o
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/709
Removed double encoding of Public Key from JS.
See Cloudstack issue CLOUDSTACK-8742 & CLOUDSTACK-8649 for information.
You can merge this pull request into a Git repository by running:
$
13 matches
Mail list logo
