Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1350
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-216423449
@swill yes that's what I meant, therefore commented that it's ready for
merge. Thanks.
---
If your project is set up for it, you can reply to this email and have you
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-216308956
@rafaelweingartner thanks for the review. :) I think what @rhtyd meant is
anything outstanding is only cosmetic, I don't think he meant the entire
discussion.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-216307184
@swill,
I did a review on the comments and discussions to get me up to date (we had
a discussion about some code duplications). Those discussions were
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-216300372
@rafaelweingartner This one seems to be in OK shape. I am missing one code
review, given that you have actively reviewed this code, can I get your final
status?
--
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-216221000
LGTM, there are some comments on cosmetics but in general we should get
this CI tested and merged cc @swill
tag:easypr
---
If your project is set up for it
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-200186297
### ACS CI BVT Run
**Sumarry:**
Build Number 121
Hypervisor xenserver
NetworkType Advanced
Passed=104
Failed=14
Skipped=4
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-176082402
@DaanHoogland I agree there should be some guideline on code style. If
these are there I think most of us will be willing to follow these. I guess it
will not be
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-176080946
@agneya2001 Sounds like you want to set the style guide. you and
@rafaelweingartner should take this discussion to a higher level and take it to
a discuss thre
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175931632
This code that was suggested:
private AccountVO createAccountVoForType(short type) {
AccountVO accountVO = new AccountVO();
accoun
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175816413
I disagree that it would make the code more complex.
That is what I meant:
```
private AccountVO createAccountVoForType(short type) {
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1350#discussion_r51006727
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -197,4 +197,58 @@ public void testProcessQuotaBalanceForAc
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1350#discussion_r51005837
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -197,4 +197,58 @@ public void testProcessQuotaBalanceForAcco
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175712977
@cristofolini your changes are incorporated can you review these.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175710627
@rafaelweingartner @bhaisaab I have taken out the duplicate account
initialisation.
---
If your project is set up for it, you can reply to this email and have y
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175708121
@agneya2001 how about you have a look at the test tomorrow and see if you
can incorporate some of the suggestions like pull out the account from the
method as a cl
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175702905
@bhaisaab I think the test cases in different methods, each one for a
single and unit test is the right way to go.
What I disagree is with the cre
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175693496
@rafaelweingartner fair points, but it would make sense if you can comment
on the diff in the context of the change.
Specific to the PR I see several testX
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175667113
I do not agree.
If people are comfortable with it, so let it be.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175656788
@rafaelweingartner It is only about realistic test data that is being
passed to the method tested. You should differentiate between the tested code
and the code
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175637289
If in a remotely distant future someone that we do not even know yet
changes that method and make use of some extra data (forgetting to check the
test cas
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175634392
@rafaelweingartner If it is a black box test then the person testing will
obviously try to pass a realistic data set, that is what I have done. It is
possible th
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175630573
It is cultural; we have to stop duplicating lines; no matter where and no
matter how simple those blocks may seem.
We also have to stop coding th
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175624327
@rafaelweingartner quality is what we are discussing and I simply do not
think that putting 3 lines of object initialisation in a method will make it
high qualit
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175609511
@agneya2001 that is exactly what I meant.
I disagree with you, letting this as they are, it is not simple. Why
duplicate code, when we can do better?
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175603740
@rafaelweingartner if you mean initialisation of AccountVO to be moved into
a method, and replacing it with a method call. I guess I would prefer it this
way as
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175601814
I know that. I just did not want to go one by one and tell you that they
are duplicated, I believe you can easily see that. Those duplicated lines I
menti
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175601093
@rafaelweingartner Can you comment on the duplicated lines. There is a way
you can get to the code and comment there.
---
If your project is set up for it, you
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175599430
Hi @agneya2001, there are a lot of duplicated lines at
âQuotaManagerImplTestâ, would you mind removing them?
Additionally, the lines you use t
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175563484
@agneya2001 LGTM again, need one more review to get this merged along with
some testing (though in this case, we've some unit tests for the change)
---
If your pr
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1289
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-175500735
merging LGTM from @DaanHoogland and @bhaisaab
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-175479331
LGTM @agneya2001 master seems to be unfrozen you'll need one more review to
merge it yourself
---
If your project is set up for it, you can reply to this email an
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-175472278
This patch cleans up any find bug issues in cloud-framework-quota and
cloud-plugin-database-quota, verifiy output below. I think we should not delay
this @remibe
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175408926
@cristofolini @bhaisaab @remibergsma test code split into simpler methods.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-174211441
I see you've put a bunch of different test cases into a single
`testLockableAccount` method. I'd strongly suggest you put each of those
different cases into th
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-173218775
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-172597438
here is my original request to look at them:
http://markmail.org/message/fqv252o3p7hmzwxz
---
If your project is set up for it, you can reply to this email
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-172594983
@remibergsma I would have to dive into my original investigation again. I
am not sure who or where the others where created anymore. lat me markmail that
for y
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-172563054
What needs to be done to fix them all?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-172558281
again code LGTM. Let's quickly run it 3 out of 5 findbugs issues will be
fixed in this.
---
If your project is set up for it, you can reply to this email and
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-172418090
@remibergsma @bhaisaab made review changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-172197923
Ping @agneya2001 let's get this resolved soon :-) All those build failure
mails hurt my eyes..
---
If your project is set up for it, you can reply to this emai
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1289#discussion_r49316008
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java ---
@@ -310,14 +269,12 @@ public String getDeploymentPlanne
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-170455889
@agneya2001 can you help fix the issues, before the freeze. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1289#discussion_r49295533
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java ---
@@ -310,14 +269,12 @@ public String getDeploymentPlanner() {
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-169753995
Would you mind changing the comments over attributes âdetailsâ and
âisDynamicâ to proper java doc style? Additionally, what about changing
them to
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1289#discussion_r49101315
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java ---
@@ -310,14 +269,12 @@ public String getDeploymentPlanne
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-16848
Ping @bhaisaab @agneya2001 the quota plugin unit tests are failing in `4.7`
and `master` branches:
```
[INFO]
-
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-167625390
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1289#discussion_r48476072
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java ---
@@ -310,14 +269,12 @@ public String getDeploymentPlanner() {
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-167554252
Based on the code LGTM, tests running
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1289#discussion_r48474787
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java ---
@@ -312,7 +271,7 @@ public String getDeploymentPlanner() {
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1289
Quota: findbug fixes
Findbug fixes for cloud-framework-quota and cloud-plugin-database-quota.
You can merge this pull request into a Git repository by running:
$ git pull https://github
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1205
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1205#issuecomment-164293808
did a code review and trustin @bhaisaab his testing skills: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1205#discussion_r47335119
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -233,9 +233,9 @@ public int compare(QuotaB
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1205#issuecomment-163885070
Alright, re-review it. LGTM.
cc @remibergsma @DaanHoogland
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1205#discussion_r47334512
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -233,9 +233,9 @@ public int compare(Quot
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1205#discussion_r47333986
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -233,9 +233,9 @@ public int compare(QuotaB
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1205#discussion_r47333902
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -83,7 +83,12 @@ public void setDomainId(Long domainI
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1205#issuecomment-163882122
LGTM (tested on Abhi's env)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1205
QUOTA: Ensuring that the dates displayed are as per user expectations
When querying db we use start of next day to query quota usage for
today, but while displaying it to user we
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1193#issuecomment-163479275
Closing this to change the case of the title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user agneya2001 closed the pull request at:
https://github.com/apache/cloudstack/pull/1193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1193#issuecomment-163330589
@agneya2001 Can you please change the title/commit to not only use capitals?
---
If your project is set up for it, you can reply to this email and have your
rep
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1193
QUOTA: ENSURING THAT THE DATES DISPLAYED ARE AS PER USER EXPECTATIONS
When querying db we use start of next day to query quota usage for
today, but while displaying it to user we
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162573927
@remibergsma sure, I'm discussing with Abhi on that minor fix. After that,
will squash/amend the message in the git log.
---
If your project is set up for it, you
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162572535
@bhaisaab Minor thing: could you also rename the title to "Implement Quota
service"?
I will make sure it will be merged before we freeze.
---
If your p
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162572129
@agneya2001 OK, please ping me when done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162529656
@bhaisaab @remibergsma there is still one issue that I am looking at now.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162506613
Abhi has fixed the issues, changes are now incorporated, commits squashed
into one.
cc @remibergsma @jburwell
LGTM, let's merge this before EOD.
---
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46797960
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software Founda
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46797933
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46796893
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Softwar
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46796854
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software Foun
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46796541
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Softwar
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46788482
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java
---
@@ -111,6 +111,30 @@ public Long getProjectId() {
p
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162403577
@remibergsma I have reviewed the code. I found a couple of minor issues.
Namely, that dates are not being defensively copied in a variety of places.
These fixes
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46785050
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaStatementResponse.java
---
@@ -0,0 +1,130 @@
+//Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784966
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,516 @@
+//Licensed to the Apach
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784960
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,516 @@
+//Licensed to the Apach
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784930
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java
---
@@ -111,6 +111,30 @@ public Long getProjectId() {
p
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784880
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaBalanceResponse.java
---
@@ -0,0 +1,153 @@
+//Licensed to the Apache So
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784858
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java
---
@@ -111,6 +111,30 @@ public Long getProjectId() {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784850
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaBalanceResponse.java
---
@@ -0,0 +1,153 @@
+//Licensed to the Apache So
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784820
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaBalanceResponse.java
---
@@ -0,0 +1,153 @@
+//Licensed to the Apache So
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784827
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaBalanceResponse.java
---
@@ -0,0 +1,153 @@
+//Licensed to the Apache So
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784798
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffUpdateCmd.java
---
@@ -0,0 +1,102 @@
+//Licensed to the Apache Sof
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784764
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffUpdateCmd.java
---
@@ -0,0 +1,102 @@
+//Licensed to the Apache Sof
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784756
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffListCmd.java
---
@@ -0,0 +1,95 @@
+//Licensed to the Apache Softwa
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784709
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java
---
@@ -0,0 +1,141 @@
+//Licensed to the Apache Softwa
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784663
--- Diff: engine/schema/src/com/cloud/usage/UsageVO.java ---
@@ -328,4 +339,48 @@ public Date getStartDate() {
public Date getEndDate()
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784674
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java
---
@@ -0,0 +1,141 @@
+//Licensed to the Apache Softwa
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784658
--- Diff: engine/schema/src/com/cloud/usage/UsageVO.java ---
@@ -328,4 +339,48 @@ public Date getStartDate() {
public Date getEndDate()
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784639
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java
---
@@ -0,0 +1,141 @@
+//Licensed to the Apache Softwa
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784622
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java
---
@@ -0,0 +1,141 @@
+//Licensed to the Apache Softwa
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784665
--- Diff: framework/db/src/com/cloud/utils/db/Transaction.java ---
@@ -35,18 +35,15 @@
if (currentTxn != null) {
da
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784647
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java
---
@@ -111,6 +111,30 @@ public Long getProjectId() {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784609
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java
---
@@ -0,0 +1,141 @@
+//Licensed to the Apache Softwa
1 - 100 of 684 matches
Mail list logo
