[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-216187512 tag:pickup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-08-26 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-134929897 We should keep it open though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-08-26 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-134929830 @bhaisaab this came out from a roadmap item suggested by @pyr, but it seems he has not had time to review and comment. So this is a bit stuck I am afraid. --- If you

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-08-26 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-134928152 anyone working on progressing this PR, I really like it and it has some good things; if no one is I can help take over some things in future (cc @rsafonseca) ---

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-08-08 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-129040864 @rsafonseca Can you close this PR? If I understand correctly the work will be split over multiple new PRs. Hope you're doing OK, talk to you soon. --- If your p

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-07-16 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-121889370 Hi @wido I've been waiting for feedback from Pyr on a thread in the dev mailing list with subject "4.6" if you want to look it up. I will nevertheless do

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-07-14 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-121150878 Hi @wido , On this comment https://github.com/apache/cloudstack/pull/372#issuecomment-110239298 I suggested that the PR should be split so we could

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-07-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-121140056 Any progress on this PR? Since I really do like the proposal, but my knowledge of Jetty/Tomcat is indeed to limited. I can test the packaging, but I have no ide

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-09 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110320351 Thanks @rsafonseca, your efforts are well appreciated, don't think otherwise. Small changes equals, atleast usually, a smaller set of testing. The Clo

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-09 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110265493 Hi @terbolous I'm here to help, so i'll try to break it down a bit in the coming days as i mentioned :) Testing this will take some time anyway, and

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-09 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110257923 I'm with Wilder & co on this. If you break it down, it's easier to test and thus merge. For instance, the mysql licensing could now potentially hol

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-09 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110255489 Hi @wilderrodrigues , @serverchief Thank you for your feedback :) I understand your point, but since there are a lot of changes and most are inte

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread serverchief
Github user serverchief commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110242990 I'm with Wilder on this. Thank you for being active and submitting really useful patches - its much appreciated. However, it would be best if you can split the c

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110239298 Hi there @rsafonseca Cool to see you contribution, thanks for that, but I think the PRs should be broken down. You listed 11 changes and said that

Re: [GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread Marcus
I assume the ASF turns their nose up to this? Have we discussed this before? https://www.mysql.com/about/legal/licensing/foss-exception/ On Mon, Jun 8, 2015 at 3:16 PM, creategui wrote: > Github user creategui commented on the pull request: > > https://github.com/apache/cloudstack/pull/372#

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110161431 How about the FOSS license exception? https://www.mysql.com/about/legal/licensing/foss-exception/ FOSS License List License NameVersion(s)/

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread creategui
Github user creategui commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110160470 bummer that Apache does not allow LGPL. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

Re: [GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread Marcus
Looks like that is LGPL http://www.apache.org/legal/resolved.html#category-x On Mon, Jun 8, 2015 at 2:57 PM, creategui wrote: > Github user creategui commented on the pull request: > > https://github.com/apache/cloudstack/pull/372#issuecomment-110153681 > > How about switching to https:

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread creategui
Github user creategui commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110153681 How about switching to https://downloads.mariadb.org/client-java/ --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread ke4qqq
Github user ke4qqq commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110152435 We can't bundle mysql-connector-java. It is licensed as GPL which is CatX and thus verboten. We can make it a system dependency. --- If your project is set up for i

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110151397 Hi @terbolous I'm in no way a licensing expert, but don't think there's any incompatibility with the licensing.. but I'll leave that for the experts to say t

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110145052 By the way, what kind of testing has this undergone? In particular I'm interested in upgrade testing, as we don't want to break any old installations. --- If your

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110144112 I'm by no means an expert on this, but isn't the reason we didn't ship the mysql connector previously due to licensing? @ke4qqq or @runseb wanna chime in? --- If

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/372 Embedded Tomcat & Jetty Well, this spruces things up a bit :) Some of the features/fixes (i may have forgotten a couple as this involved a lot of changes ;) ) - Embedded Tom