Github user serverchief commented on the pull request:

    https://github.com/apache/cloudstack/pull/372#issuecomment-110242990
  
    I'm with Wilder on this. Thank you for being active and submitting really 
useful patches - its much appreciated. However, it would be best if you can 
split the commits into multiples - as 1 fix per commit (or more if related). 
    
    Mainly, it would be easier to revert a commit - in case something is wrong 
and loose 1 functionality VS reverting 1 commit because 1 item is broken, but 
as cascade effect, 10 fixes will be reverted as well. 
    
    Regards
    ilya


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to