Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/944
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/944#issuecomment-161558537
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_v
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/944#issuecomment-161352035
LGTM (just code review)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/944#issuecomment-160277954
@DaanHoogland , I have fixed those trailing lines for @pedro-martins
---
If your project is set up for it, you can reply to this email and have your
reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/944#issuecomment-159190185
@pedro-martins checkstyle is complaining about trailing spaces in
CitrixResourceBaseTest
---
If your project is set up for it, you can reply to this email and
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/944#issuecomment-158929670
Squash done. Thx guys
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/944#issuecomment-158925001
@pedro-martins I am crazy/not paying attention, you are right.
still, can you rebase on post 4.6.0, instead of merge?
---
If your project is set up for
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/944#issuecomment-158924129
Hi @DaanHoogland, in that "CitrixResourceBaseTest.
testGetPathFilesExeption" method, there is no @test annotation.
---
If your project is set up for it, y
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/944#issuecomment-158923595
@pedro-martins I think you should remove the Test annotation then. It is
not supposed to run as a test itself, is it?
---
If your project is set up for it, you
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/944#issuecomment-158921322
Thanks for your review Daan.
The purpose of this test is to check if an exception is thrown. The point
is that, we have several class that we need to
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/944#issuecomment-158683799
@pedro-martins like the code one question about CitrixResourceBaseTest. And
also: can you rebase on a commit beyond 4.6 and not merge, please?
---
If your proj
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/944#discussion_r45550989
--- Diff:
plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/CitrixResourceBaseTest.java
---
@@ -0,0 +1,37 @@
+package c
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/944#issuecomment-158673838
Hi @pedro-martins I can run some tests but please remove the merge commit.
Thanks!
---
If your project is set up for it, you can reply to this email and have yo
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/944#issuecomment-158667466
merged with master top version, someone can check this PR?
=) thx guys.
---
If your project is set up for it, you can reply to this email and have your
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/944#issuecomment-149024959
@pedro-martins, it is nice that you wrote more tests to a class. However,
there are some check style problems:
C:\Users\Rafael\git\cloudstack\plug
GitHub user pedro-martins opened a pull request:
https://github.com/apache/cloudstack/pull/944
Create test cases to getPatchFilePath method and class names changed
In this commit we created tests cases for the respective classes in package
âcom.cloud.hypervisor.xenserver.resourc
16 matches
Mail list logo
