Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/944#issuecomment-149024959
@pedro-martins, it is nice that you wrote more tests to a class. However,
there are some check style problems:
C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:16:
Line has trailing spaces.
C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:18:
Line has trailing spaces.
C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:19:
Line has trailing spaces.
C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:21:
Line has trailing spaces.
C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:23:
Line has trailing spaces.
C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:26:
Line has trailing spaces.
C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:28:
Line has trailing spaces.
C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:29:
Line has trailing spaces.
C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:32:
Line has trailing spaces.
C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\XcpOssResourceTest.java:38:
Line has trailing spaces.
C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\XcpOssResourceTest.java:44:
Line has trailing spaces.
C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\XcpServerResourceTest.java:39:
Line has trailing spaces.
C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\XcpServerResourceTest.java:45:
Line has trailing spaces.
C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\XenServer650ResourceTest.java:38:
Line has trailing spaces.
Could you configure your eclipse java formatter?
Here you can find a detailed explanation on how to do that:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
